Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix storage benchwrapper to not require an emulator #7143

Merged
merged 3 commits into from Feb 25, 2020
Merged

test: fix storage benchwrapper to not require an emulator #7143

merged 3 commits into from Feb 25, 2020

Conversation

crwilcox
Copy link

@crwilcox crwilcox commented Feb 25, 2020 •
edited

Extends the java benchwrapper to support live benchmarking.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 25, 2020
@crwilcox
Copy link
Author

NOTE: when I tried to run the benchmark off of this branch, it failed to build. This doesn't seem related to my change.

[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 9.369 s
[INFO] Finished at: 2020-02-24T18:13:56-08:00
[INFO] Final Memory: 29M/69M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.6.0:java (default-cli) on project benchwrapper: An exception occured while executing the Java class. io.grpc.Deadline.getSystemTicker()Lio/grpc/Deadline$Ticker; -> [Help 1]

chingor13
chingor13 reviewed Feb 25, 2020
View reviewed changes
...torage-benchwrapper/src/main/java/com/google/cloud/benchwrapper/StorageBenchWrapperImpl.java Outdated
@@ -32,10 +32,16 @@
private Storage client;

public StorageBenchWrapperImpl(String storageEmulatorHost) {
client = StorageOptions.newBuilder()
if (storageEmulatorHost.isEmpty()){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally this would be a null check (or both null and empty) versus an empty string

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I thought isEmpty also did null, but this may be me comparing it to isNullOrEmpty in .NET

frankyn
frankyn requested changes Feb 25, 2020
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit.

google-cloud-testing/storage-benchwrapper/src/main/java/com/google/cloud/benchwrapper/Main.java Outdated Show resolved Hide resolved
frankyn
frankyn approved these changes Feb 25, 2020
View reviewed changes
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chingor13 has a null check change request.

Overall LGTM otherwise.

@crwilcox crwilcox merged commit 9340407 into master Feb 25, 2020
@crwilcox crwilcox deleted the perf branch February 25, 2020 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 left review comments

@frankyn frankyn frankyn approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crwilcox @chingor13 @frankyn @googlebot