Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some final changes to the GCS NIO API #770

Closed
wants to merge 5 commits into from

Commits on Mar 29, 2016

  1. Make some final changes to the GCS NIO API

    This change prepares GCS NIO to be merged into master, by making some
    last minute API changes.
    
    - Documentation has been added to many methods to clarify the preferred
      method for instantiating the library, which is the non-SPI version.
    
    - Unit tests have been updated to not rely on the SPI, because there's
      no way to guarantee clean isolation of SPI usage across tests. We'll
      be relying on integration testing to test the SPI interface.
    
    - The unit testing methodology has changed somewhat. FakeStorageRpc
      should be a private final field on the test class so, if desired,
      we'll be able to have the tests dip directly into fake memory.
    
    - IOException has been added back to the throws of file system close, in
      case we decide to implement the "close all owned channels" thing into
      that method in the future.
    
    - The getters on the configuration class have been made package-private,
      since there's no foreseeable reason they would be needed by the user.
    
    - Injectable constructors have been added for Dagger 2 users.
    
    In a future change, a README.md file will be added to replace the
    documentation in the package-info.java file.
    jart committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    cd7cf1a View commit details
    Browse the repository at this point in the history
  2. Address review comments

    jart committed Mar 29, 2016
    Configuration menu
    Copy the full SHA
    2ce11cb View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2016

  1. refactor integration test

    jart committed Mar 30, 2016
    Configuration menu
    Copy the full SHA
    af45b49 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2016

  1. More review comments

    jart committed Mar 31, 2016
    Configuration menu
    Copy the full SHA
    cb372fd View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2016

  1. more review comments

    jart committed Apr 6, 2016
    Configuration menu
    Copy the full SHA
    4ce43d0 View commit details
    Browse the repository at this point in the history