chore: fixing missed updates to Release Please branch #8601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suztomo
changed the title
suztomo
added
the
kokoro:force-run
ddixit14
approved these changes
Oct 13, 2022
|
Can you please update java-notification version in .release-please-manifest file? And remove snapshot from the root pom? |
Given the root pom is not published to Maven Central, I don't think it's needed. What's the problem of having the root pom with snapshot version? |
release-please
bot
force-pushed
the
release-please--branches--main
branch
from
ed5dbfd
to
2e8294c
Compare
|
Tests all succeeded. No need to merge. |
release-please
bot
force-pushed
the
release-please--branches--main
branch
7 times, most recently
from
74f27fc
to
60ff8c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request to update the release please branch #8444.
generation/apply_current_versions.sh)