Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add centralized retries to all java-vision integration tests. Simplify. #8740

Merged
merged 3 commits into from Nov 8, 2022
Merged

fix: Add centralized retries to all java-vision integration tests. Simplify. #8740

merged 3 commits into from Nov 8, 2022

Conversation

burkedavison
Copy link
Contributor

No description provided.

meltsufin
meltsufin approved these changes Nov 8, 2022
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simplification, but I do wonder if we can do something better than 30 second delays between tries. For another time though.

@burkedavison burkedavison merged commit 5622215 into main Nov 8, 2022
@burkedavison burkedavison deleted the java-vision-retries branch November 8, 2022 22:13
@release-please release-please bot mentioned this pull request Nov 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@burkedavison @meltsufin