Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [cloudbuild] add update_mask to UpdateBuildTriggerRequest proto #9704

Merged
merged 4 commits into from Aug 2, 2023
Merged

feat: [cloudbuild] add update_mask to UpdateBuildTriggerRequest proto #9704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec72905
feat: Add automap_substitutions flag to use substitutions as envs in …
gcf-owl-bot[bot] Jul 26, 2023
a61e099
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 26, 2023
1f3d4ec
feat: add update_mask to UpdateBuildTriggerRequest proto
gcf-owl-bot[bot] Jul 31, 2023
3fbfda8
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Jul 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions java-cloudbuild/README.md
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.19.0</version>
<version>26.20.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down Expand Up @@ -195,7 +195,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[kokoro-badge-link-5]: http://storage.googleapis.com/cloud-devrel-public/java/badges/google-cloud-java/java11.html
[stability-image]: https://img.shields.io/badge/stability-stable-green
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.cloud/google-cloud-build.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-build/3.23.0
[maven-version-link]: https://central.sonatype.com/artifact/com.google.cloud/google-cloud-build/3.24.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
2 changes: 2 additions & 0 deletions ...e-cloud-build/src/main/java/com/google/cloud/devtools/cloudbuild/v1/CloudBuildClient.java
View file
Open in desktop
Expand Up @@ -1574,6 +1574,7 @@ public final BuildTrigger updateBuildTrigger(
* .setProjectId("projectId-894832108")
* .setTriggerId("triggerId-648752909")
* .setTrigger(BuildTrigger.newBuilder().build())
* .setUpdateMask(FieldMask.newBuilder().build())
* .build();
* BuildTrigger response = cloudBuildClient.updateBuildTrigger(request);
* }
Expand Down Expand Up @@ -1606,6 +1607,7 @@ public final BuildTrigger updateBuildTrigger(UpdateBuildTriggerRequest request)
* .setProjectId("projectId-894832108")
* .setTriggerId("triggerId-648752909")
* .setTrigger(BuildTrigger.newBuilder().build())
* .setUpdateMask(FieldMask.newBuilder().build())
* .build();
* ApiFuture<BuildTrigger> future =
* cloudBuildClient.updateBuildTriggerCallable().futureCall(request);
Expand Down
1 change: 1 addition & 0 deletions ...ld/src/main/java/com/google/cloud/devtools/cloudbuild/v1/stub/HttpJsonCloudBuildStub.java
View file
Open in desktop
Expand Up @@ -535,6 +535,7 @@ public class HttpJsonCloudBuildStub extends CloudBuildStub {
Map<String, List<String>> fields = new HashMap<>();
ProtoRestSerializer<UpdateBuildTriggerRequest> serializer =
ProtoRestSerializer.create();
serializer.putQueryParam(fields, "updateMask", request.getUpdateMask());
serializer.putQueryParam(fields, "$alt", "json;enum-encoding=int");
return fields;
})
Expand Down