Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [confidentialcomputing] Mark all fields Optional for ContainerImageSignagure proto #9736

Merged
merged 2 commits into from
Aug 4, 2023
Merged

feat: [confidentialcomputing] Mark all fields Optional for ContainerImageSignagure proto #9736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0dc486e
feat: Mark all fields `Optional` for `ContainerImageSignagure` proto
gcf-owl-bot[bot] Aug 4, 2023
25229d1
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion java-confidentialcomputing/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ If you are using Maven with [BOM][libraries-bom], add this to your pom.xml file:
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom</artifactId>
<version>26.19.0</version>
<version>26.21.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
Expand Down
76 changes: 38 additions & 38 deletions ...g-v1/src/main/java/com/google/cloud/confidentialcomputing/v1/ContainerImageSignature.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,12 @@ public static final com.google.protobuf.Descriptors.Descriptor getDescriptor() {
*
*
* <pre>
* Required. The binary signature payload following the SimpleSigning format
* Optional. The binary signature payload following the SimpleSigning format
* https://github.com/sigstore/cosign/blob/main/specs/SIGNATURE_SPEC.md#simple-signing.
* This payload includes the container image digest.
* </pre>
*
* <code>bytes payload = 1 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes payload = 1 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The payload.
*/
Expand All @@ -92,7 +92,7 @@ public com.google.protobuf.ByteString getPayload() {
*
*
* <pre>
* Required. A signature over the payload.
* Optional. A signature over the payload.
* The container image digest is incorporated into the signature as follows:
* 1. Generate a SimpleSigning format payload that includes the container
* image digest.
Expand All @@ -101,7 +101,7 @@ public com.google.protobuf.ByteString getPayload() {
* `Sign(sha256(SimpleSigningPayload(sha256(Image Manifest))))`
* </pre>
*
* <code>bytes signature = 2 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes signature = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The signature.
*/
Expand All @@ -116,10 +116,10 @@ public com.google.protobuf.ByteString getSignature() {
*
*
* <pre>
* Required. An associated public key used to verify the signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>bytes public_key = 3 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes public_key = 3 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The publicKey.
*/
Expand All @@ -134,11 +134,11 @@ public com.google.protobuf.ByteString getPublicKey() {
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @return The enum numeric value on the wire for sigAlg.
Expand All @@ -151,11 +151,11 @@ public int getSigAlgValue() {
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @return The sigAlg.
Expand Down Expand Up @@ -592,12 +592,12 @@ public Builder mergeFrom(
*
*
* <pre>
* Required. The binary signature payload following the SimpleSigning format
* Optional. The binary signature payload following the SimpleSigning format
* https://github.com/sigstore/cosign/blob/main/specs/SIGNATURE_SPEC.md#simple-signing.
* This payload includes the container image digest.
* </pre>
*
* <code>bytes payload = 1 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes payload = 1 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The payload.
*/
Expand All @@ -609,12 +609,12 @@ public com.google.protobuf.ByteString getPayload() {
*
*
* <pre>
* Required. The binary signature payload following the SimpleSigning format
* Optional. The binary signature payload following the SimpleSigning format
* https://github.com/sigstore/cosign/blob/main/specs/SIGNATURE_SPEC.md#simple-signing.
* This payload includes the container image digest.
* </pre>
*
* <code>bytes payload = 1 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes payload = 1 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @param value The payload to set.
* @return This builder for chaining.
Expand All @@ -632,12 +632,12 @@ public Builder setPayload(com.google.protobuf.ByteString value) {
*
*
* <pre>
* Required. The binary signature payload following the SimpleSigning format
* Optional. The binary signature payload following the SimpleSigning format
* https://github.com/sigstore/cosign/blob/main/specs/SIGNATURE_SPEC.md#simple-signing.
* This payload includes the container image digest.
* </pre>
*
* <code>bytes payload = 1 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes payload = 1 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return This builder for chaining.
*/
Expand All @@ -653,7 +653,7 @@ public Builder clearPayload() {
*
*
* <pre>
* Required. A signature over the payload.
* Optional. A signature over the payload.
* The container image digest is incorporated into the signature as follows:
* 1. Generate a SimpleSigning format payload that includes the container
* image digest.
Expand All @@ -662,7 +662,7 @@ public Builder clearPayload() {
* `Sign(sha256(SimpleSigningPayload(sha256(Image Manifest))))`
* </pre>
*
* <code>bytes signature = 2 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes signature = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The signature.
*/
Expand All @@ -674,7 +674,7 @@ public com.google.protobuf.ByteString getSignature() {
*
*
* <pre>
* Required. A signature over the payload.
* Optional. A signature over the payload.
* The container image digest is incorporated into the signature as follows:
* 1. Generate a SimpleSigning format payload that includes the container
* image digest.
Expand All @@ -683,7 +683,7 @@ public com.google.protobuf.ByteString getSignature() {
* `Sign(sha256(SimpleSigningPayload(sha256(Image Manifest))))`
* </pre>
*
* <code>bytes signature = 2 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes signature = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @param value The signature to set.
* @return This builder for chaining.
Expand All @@ -701,7 +701,7 @@ public Builder setSignature(com.google.protobuf.ByteString value) {
*
*
* <pre>
* Required. A signature over the payload.
* Optional. A signature over the payload.
* The container image digest is incorporated into the signature as follows:
* 1. Generate a SimpleSigning format payload that includes the container
* image digest.
Expand All @@ -710,7 +710,7 @@ public Builder setSignature(com.google.protobuf.ByteString value) {
* `Sign(sha256(SimpleSigningPayload(sha256(Image Manifest))))`
* </pre>
*
* <code>bytes signature = 2 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes signature = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return This builder for chaining.
*/
Expand All @@ -726,10 +726,10 @@ public Builder clearSignature() {
*
*
* <pre>
* Required. An associated public key used to verify the signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>bytes public_key = 3 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes public_key = 3 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The publicKey.
*/
Expand All @@ -741,10 +741,10 @@ public com.google.protobuf.ByteString getPublicKey() {
*
*
* <pre>
* Required. An associated public key used to verify the signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>bytes public_key = 3 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes public_key = 3 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @param value The publicKey to set.
* @return This builder for chaining.
Expand All @@ -762,10 +762,10 @@ public Builder setPublicKey(com.google.protobuf.ByteString value) {
*
*
* <pre>
* Required. An associated public key used to verify the signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>bytes public_key = 3 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes public_key = 3 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return This builder for chaining.
*/
Expand All @@ -781,11 +781,11 @@ public Builder clearPublicKey() {
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @return The enum numeric value on the wire for sigAlg.
Expand All @@ -798,11 +798,11 @@ public int getSigAlgValue() {
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @param value The enum numeric value on the wire for sigAlg to set.
Expand All @@ -818,11 +818,11 @@ public Builder setSigAlgValue(int value) {
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @return The sigAlg.
Expand All @@ -839,11 +839,11 @@ public com.google.cloud.confidentialcomputing.v1.SigningAlgorithm getSigAlg() {
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @param value The sigAlg to set.
Expand All @@ -862,11 +862,11 @@ public Builder setSigAlg(com.google.cloud.confidentialcomputing.v1.SigningAlgori
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @return This builder for chaining.
Expand Down
20 changes: 10 additions & 10 deletions ...main/java/com/google/cloud/confidentialcomputing/v1/ContainerImageSignatureOrBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ public interface ContainerImageSignatureOrBuilder
*
*
* <pre>
* Required. The binary signature payload following the SimpleSigning format
* Optional. The binary signature payload following the SimpleSigning format
* https://github.com/sigstore/cosign/blob/main/specs/SIGNATURE_SPEC.md#simple-signing.
* This payload includes the container image digest.
* </pre>
*
* <code>bytes payload = 1 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes payload = 1 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The payload.
*/
Expand All @@ -42,7 +42,7 @@ public interface ContainerImageSignatureOrBuilder
*
*
* <pre>
* Required. A signature over the payload.
* Optional. A signature over the payload.
* The container image digest is incorporated into the signature as follows:
* 1. Generate a SimpleSigning format payload that includes the container
* image digest.
Expand All @@ -51,7 +51,7 @@ public interface ContainerImageSignatureOrBuilder
* `Sign(sha256(SimpleSigningPayload(sha256(Image Manifest))))`
* </pre>
*
* <code>bytes signature = 2 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes signature = 2 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The signature.
*/
Expand All @@ -61,10 +61,10 @@ public interface ContainerImageSignatureOrBuilder
*
*
* <pre>
* Required. An associated public key used to verify the signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>bytes public_key = 3 [(.google.api.field_behavior) = REQUIRED];</code>
* <code>bytes public_key = 3 [(.google.api.field_behavior) = OPTIONAL];</code>
*
* @return The publicKey.
*/
Expand All @@ -74,11 +74,11 @@ public interface ContainerImageSignatureOrBuilder
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @return The enum numeric value on the wire for sigAlg.
Expand All @@ -88,11 +88,11 @@ public interface ContainerImageSignatureOrBuilder
*
*
* <pre>
* Required. The algorithm used to produce the container image signature.
* Optional. Reserved for future use.
* </pre>
*
* <code>
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = REQUIRED];
* .google.cloud.confidentialcomputing.v1.SigningAlgorithm sig_alg = 4 [(.google.api.field_behavior) = OPTIONAL];
* </code>
*
* @return The sigAlg.
Expand Down
6 changes: 3 additions & 3 deletions ...ialcomputing-v1/src/main/java/com/google/cloud/confidentialcomputing/v1/ServiceProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,10 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "image_signatures\030\001 \003(\0132>.google.cloud.co"
+ "nfidentialcomputing.v1.ContainerImageSig"
+ "natureB\004\342A\001\001\"\263\001\n\027ContainerImageSignature"
+ "\022\025\n\007payload\030\001 \001(\014B\004\342A\001\002\022\027\n\tsignature\030\002 \001"
+ "(\014B\004\342A\001\002\022\030\n\npublic_key\030\003 \001(\014B\004\342A\001\002\022N\n\007si"
+ "\022\025\n\007payload\030\001 \001(\014B\004\342A\001\001\022\027\n\tsignature\030\002 \001"
+ "(\014B\004\342A\001\001\022\030\n\npublic_key\030\003 \001(\014B\004\342A\001\001\022N\n\007si"
+ "g_alg\030\004 \001(\01627.google.cloud.confidentialc"
+ "omputing.v1.SigningAlgorithmB\004\342A\001\002*\177\n\020Si"
+ "omputing.v1.SigningAlgorithmB\004\342A\001\001*\177\n\020Si"
+ "gningAlgorithm\022!\n\035SIGNING_ALGORITHM_UNSP"
+ "ECIFIED\020\000\022\025\n\021RSASSA_PSS_SHA256\020\001\022\032\n\026RSAS"
+ "SA_PKCS1V15_SHA256\020\002\022\025\n\021ECDSA_P256_SHA25"
Expand Down