fix: drop support for node.js 4.x and 9.x (#106)

* fix: drop support for node.js 4.x and 9.x * fix my blunder
googleapis · Jul 10, 2018 · 06c239e · 06c239e
1 parent 5250c12
commit 06c239e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 36 deletions.
diff --git a/packages/google-cloud-node/.circleci/config.yml b/packages/google-cloud-node/.circleci/config.yml
@@ -3,32 +3,24 @@ workflows:
   version: 2
   tests:
     jobs: &workflow_jobs
-      - node4:
+      - node6:
           filters: &all_commits
             tags:
               only: /.*/
-      - node6:
-          filters: *all_commits
       - node8:
           filters: *all_commits
-      - node9:
-          filters: *all_commits
       - node10:
           filters: *all_commits
       - lint:
           requires:
-            - node4
             - node6
             - node8
-            - node9
             - node10
           filters: *all_commits
       - docs:
           requires:
-            - node4
             - node6
             - node8
-            - node9
             - node10
           filters: *all_commits
       - system_tests:
@@ -62,9 +54,9 @@ workflows:
               only: master
     jobs: *workflow_jobs
 jobs:
-  node4:
+  node6:
     docker:
-      - image: 'node:4'
+      - image: 'node:6'
         user: node
     steps: &unit_tests_steps
       - checkout
@@ -86,28 +78,14 @@ jobs:
             npm install
           environment:
             NPM_CONFIG_PREFIX: /home/node/.npm-global
-      - run:
-          name: Run unit tests.
-          command: npm test
-      - run:
-          name: Submit coverage data to codecov.
-          command: node_modules/.bin/codecov
-          when: always
-  node6:
-    docker:
-      - image: 'node:6'
-        user: node
-    steps: *unit_tests_steps
+      - run: npm test
+      - run: node_modules/.bin/codecov
+
   node8:
     docker:
       - image: 'node:8'
         user: node
     steps: *unit_tests_steps
-  node9:
-    docker:
-      - image: 'node:9'
-        user: node
-    steps: *unit_tests_steps
   node10:
     docker:
       - image: 'node:10'
@@ -201,9 +179,5 @@ jobs:
         user: node
     steps:
       - checkout
-      - run:
-          name: Set NPM authentication.
-          command: 'echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc'
-      - run:
-          name: Publish the module to npm.
-          command: npm publish
+      - run: 'echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > ~/.npmrc'
+      - run: npm publish
diff --git a/packages/google-cloud-node/package.json b/packages/google-cloud-node/package.json
@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": ">=4.0.0"
+    "node": ">=6.0.0"
   },
   "repository": "googleapis/nodejs-speech",
   "main": "./src/index.js",

diff --git a/packages/google-cloud-node/samples/package.json b/packages/google-cloud-node/samples/package.json
@@ -6,7 +6,7 @@
   "author": "Google Inc.",
   "repository": "googleapis/nodejs-speech",
   "engines": {
-    "node": ">=4.0.0"
+    "node": ">=6.0.0"
   },
   "scripts": {
     "test": "ava -T 20s --verbose system-test/*.test.js"