Enable noImplicitThis in tsconfig (#115)

Resolves #69
googleapis · Sep 5, 2018 · 22f8ff3 · 22f8ff3
1 parent 039c9a2
commit 22f8ff3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/packages/google-cloud-translate/test/index.ts b/packages/google-cloud-translate/test/index.ts
@@ -47,8 +47,12 @@ const fakeUtil = extend({}, util, {
 });
 const originalFakeUtil = extend(true, {}, fakeUtil);
 
-function FakeService() {
-  this.calledWith_ = arguments;
+class FakeService {
+  calledWith_: IArguments;
+  request?: Function;
+  constructor() {
+    this.calledWith_ = arguments;
+  }
 }
 
 describe('Translate', () => {
@@ -525,10 +529,10 @@ describe('Translate', () => {
 
   describe('request', () => {
     describe('OAuth mode', () => {
-      let request: r.Request;
+      let request: Function;
 
       beforeEach(() => {
-        request = FakeService.prototype.request;
+        request = FakeService.prototype.request!;
       });
 
       afterEach(() => {

diff --git a/packages/google-cloud-translate/tsconfig.json b/packages/google-cloud-translate/tsconfig.json
@@ -2,8 +2,7 @@
   "extends": "./node_modules/gts/tsconfig-google.json",
   "compilerOptions": {
     "rootDir": ".",
-    "outDir": "build",
-    "noImplicitThis": false
+    "outDir": "build"
   },
   "include": [
     "src/*.ts",