bigquery: check for apiResponse presence (#1853)

googleapis · Dec 2, 2016 · 61b04a1 · 61b04a1
1 parent 978b1f5
commit 61b04a1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/packages/bigquery/src/job.js b/packages/bigquery/src/job.js
@@ -317,7 +317,7 @@ Job.prototype.getQueryResultsStream = function(options) {
  */
 Job.prototype.poll_ = function(callback) {
   this.getMetadata(function(err, metadata, apiResponse) {
-    if (apiResponse.status && apiResponse.status.errors) {
+    if (!err && apiResponse.status && apiResponse.status.errors) {
       err = common.util.ApiError(apiResponse.status);
     }
 

diff --git a/packages/bigquery/test/job.js b/packages/bigquery/test/job.js
@@ -277,11 +277,10 @@ describe('BigQuery/Job', function() {
 
     describe('API error', function() {
       var error = new Error('Error.');
-      var apiResponse = {};
 
       beforeEach(function() {
         job.getMetadata = function(callback) {
-          callback(error, null, apiResponse);
+          callback(error);
         };
       });