Skip to content

Commit

Permalink
chore: assert.deelEqual => assert.deepStrictEqual (#81)
Browse files Browse the repository at this point in the history
  • Loading branch information
@jkwlui @JustinBeckwith
jkwlui authored and JustinBeckwith committed Jul 30, 2018
1 parent 3fb4cb5 commit 952b787
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 19 deletions.
4 changes: 2 additions & 2 deletions packages/google-cloud-translate/system-test/translate.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ describe('translate', function() {
return language.code === 'en';
})[0];

assert.deepEqual(englishResult, {
assert.deepStrictEqual(englishResult, {
code: 'en',
name: 'English',
});
Expand All @@ -146,7 +146,7 @@ describe('translate', function() {
return language.code === 'en';
})[0];

assert.deepEqual(englishResult, {
assert.deepStrictEqual(englishResult, {
code: 'en',
name: 'inglés',
});
Expand Down
34 changes: 17 additions & 17 deletions packages/google-cloud-translate/test/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -83,10 +83,10 @@ describe('Translate', () => {
'https://translation.googleapis.com/language/translate/v2';

assert.strictEqual(calledWith.baseUrl, baseUrl);
assert.deepEqual(calledWith.scopes, [
assert.deepStrictEqual(calledWith.scopes, [
'https://www.googleapis.com/auth/cloud-platform',
]);
assert.deepEqual(calledWith.packageJson, pkgJson);
assert.deepStrictEqual(calledWith.packageJson, pkgJson);
assert.strictEqual(calledWith.projectIdRequired, false);
});

Expand Down Expand Up @@ -149,7 +149,7 @@ describe('Translate', () => {
translate.request = reqOpts => {
assert.strictEqual(reqOpts.uri, '/detect');
assert.strictEqual(reqOpts.method, 'POST');
assert.deepEqual(reqOpts.json, {q: [INPUT]});
assert.deepStrictEqual(reqOpts.json, {q: [INPUT]});
done();
};

Expand Down Expand Up @@ -208,27 +208,27 @@ describe('Translate', () => {
it('should execute callback with results & API response', done => {
translate.detect(INPUT, (err, results, apiResponse_) => {
assert.ifError(err);
assert.deepEqual(results, expectedResults);
assert.deepStrictEqual(results, expectedResults);
assert.strictEqual(apiResponse_, apiResponse);
assert.deepEqual(apiResponse_, originalApiResponse);
assert.deepStrictEqual(apiResponse_, originalApiResponse);
done();
});
});

it('should execute callback with multiple results', done => {
translate.detect([INPUT, INPUT], (err, results) => {
assert.ifError(err);
assert.deepEqual(results, [expectedResults]);
assert.deepStrictEqual(results, [expectedResults]);
done();
});
});

it('should return an array if input was an array', done => {
translate.detect([INPUT], (err, results, apiResponse_) => {
assert.ifError(err);
assert.deepEqual(results, [expectedResults]);
assert.deepStrictEqual(results, [expectedResults]);
assert.strictEqual(apiResponse_, apiResponse);
assert.deepEqual(apiResponse_, originalApiResponse);
assert.deepStrictEqual(apiResponse_, originalApiResponse);
done();
});
});
Expand All @@ -239,7 +239,7 @@ describe('Translate', () => {
it('should make the correct API request', done => {
translate.request = reqOpts => {
assert.strictEqual(reqOpts.uri, '/languages');
assert.deepEqual(reqOpts.qs, {
assert.deepStrictEqual(reqOpts.qs, {
target: 'en',
});
done();
Expand All @@ -251,7 +251,7 @@ describe('Translate', () => {
it('should make the correct API request with target', done => {
translate.request = reqOpts => {
assert.strictEqual(reqOpts.uri, '/languages');
assert.deepEqual(reqOpts.qs, {
assert.deepStrictEqual(reqOpts.qs, {
target: 'es',
});
done();
Expand Down Expand Up @@ -316,7 +316,7 @@ describe('Translate', () => {
it('should exec callback with languages', done => {
translate.getLanguages((err, languages, apiResponse_) => {
assert.ifError(err);
assert.deepEqual(languages, expectedResults);
assert.deepStrictEqual(languages, expectedResults);
assert.strictEqual(apiResponse_, apiResponse);
done();
});
Expand Down Expand Up @@ -422,7 +422,7 @@ describe('Translate', () => {
translate.request = reqOpts => {
assert.strictEqual(reqOpts.uri, '');
assert.strictEqual(reqOpts.method, 'POST');
assert.deepEqual(reqOpts.json, {
assert.deepStrictEqual(reqOpts.json, {
q: [INPUT],
format: 'text',
source: SOURCE_LANG_CODE,
Expand Down Expand Up @@ -478,7 +478,7 @@ describe('Translate', () => {
it('should execute callback with results & API response', done => {
translate.translate(INPUT, OPTIONS, (err, translations, resp) => {
assert.ifError(err);
assert.deepEqual(translations, expectedResults);
assert.deepStrictEqual(translations, expectedResults);
assert.strictEqual(resp, apiResponse);
done();
});
Expand All @@ -488,15 +488,15 @@ describe('Translate', () => {
const input = [INPUT, INPUT];
translate.translate(input, OPTIONS, (err, translations) => {
assert.ifError(err);
assert.deepEqual(translations, [expectedResults]);
assert.deepStrictEqual(translations, [expectedResults]);
done();
});
});

it('should return an array if input was an array', done => {
translate.translate([INPUT], OPTIONS, (err, translations) => {
assert.ifError(err);
assert.deepEqual(translations, [expectedResults]);
assert.deepStrictEqual(translations, [expectedResults]);
done();
});
});
Expand Down Expand Up @@ -548,7 +548,7 @@ describe('Translate', () => {
const getUserAgentFn = fakeUtil.getUserAgentFromPackageJson;
fakeUtil.getUserAgentFromPackageJson = (packageJson) => {
fakeUtil.getUserAgentFromPackageJson = getUserAgentFn;
assert.deepEqual(packageJson, pkgJson);
assert.deepStrictEqual(packageJson, pkgJson);
return userAgent;
};

Expand All @@ -574,7 +574,7 @@ describe('Translate', () => {
expectedReqOpts.uri = translate.baseUrl + reqOpts.uri;

makeRequestOverride = (reqOpts, options, callback) => {
assert.deepEqual(reqOpts, expectedReqOpts);
assert.deepStrictEqual(reqOpts, expectedReqOpts);
assert.strictEqual(options, translate.options);
callback(); // done()
};
Expand Down

0 comments on commit 952b787

Please sign in to comment.