chore: run the generator, fix synth script (#755)

* chore: run th generator, fix synth script * test: remove comment
googleapis · Apr 10, 2020 · c768b81 · c768b81
1 parent a748a48
commit c768b81
Show file tree

Hide file tree

Showing 21 changed files with 147 additions and 121 deletions.
diff --git a/packages/google-cloud-vision/.jsdoc.js b/packages/google-cloud-vision/.jsdoc.js
@@ -40,7 +40,7 @@ module.exports = {
     includePattern: '\\.js$'
   },
   templates: {
-    copyright: 'Copyright 2019 Google, LLC.',
+    copyright: 'Copyright 2020 Google LLC',
     includeDate: false,
     sourceFiles: false,
     systemName: '@google-cloud/vision',

diff --git a/packages/google-cloud-vision/.prettierrc.js b/packages/google-cloud-vision/.prettierrc.js
@@ -4,7 +4,7 @@
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
-//      http://www.apache.org/licenses/LICENSE-2.0
+//      https://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,

diff --git a/packages/google-cloud-vision/package.json b/packages/google-cloud-vision/package.json
@@ -29,7 +29,7 @@
   "scripts": {
     "test": "c8 mocha build/test",
     "samples-test": "cd samples/ && npm link ../ && npm install && npm test && cd ../",
-    "lint": "gts fix && eslint --fix samples/*.js",
+    "lint": "gts fix",
     "docs": "jsdoc -c .jsdoc.js",
     "system-test": "mocha build/system-test",
     "fix": "gts fix",
@@ -52,7 +52,6 @@
     "@types/is": "0.0.21",
     "@types/mocha": "^7.0.1",
     "@types/node": "^13.7.4",
-    "@types/is": "0.0.21",
     "@types/sinon": "^9.0.0",
     "@types/uuid": "^3.4.7",
     "c8": "^7.1.0",

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1/image_annotator.proto
@@ -676,7 +676,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](/vision/docs/languages).
+  // [supported languages](https://cloud.google.com/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p1beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p1beta1/image_annotator.proto
@@ -502,7 +502,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](/vision/docs/languages).
+  // [supported languages](https://cloud.google.com/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p2beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p2beta1/image_annotator.proto
@@ -533,7 +533,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](/vision/docs/languages).
+  // [supported languages](https://cloud.google.com/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p3beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p3beta1/image_annotator.proto
@@ -561,7 +561,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](/vision/docs/languages).
+  // [supported languages](https://cloud.google.com/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/image_annotator.proto b/packages/google-cloud-vision/protos/google/cloud/vision/v1p4beta1/image_annotator.proto
@@ -632,7 +632,7 @@ message ImageContext {
   // setting a hint will help get better results (although it will be a
   // significant hindrance if the hint is wrong). Text detection returns an
   // error if one or more of the specified languages is not one of the
-  // [supported languages](/vision/docs/languages).
+  // [supported languages](https://cloud.google.com/vision/docs/languages).
   repeated string language_hints = 2;
 
   // Parameters for crop hints annotation request.

diff --git a/packages/google-cloud-vision/protos/protos.js b/packages/google-cloud-vision/protos/protos.js
@@ -28,7 +28,7 @@
     var $Reader = $protobuf.Reader, $Writer = $protobuf.Writer, $util = $protobuf.util;
 
     // Exported root namespace
-    var $root = $protobuf.roots["default"] || ($protobuf.roots["default"] = {});
+    var $root = $protobuf.roots._google_cloud_vision_1_11_0_protos || ($protobuf.roots._google_cloud_vision_1_11_0_protos = {});
 
     $root.google = (function() {
 

diff --git a/packages/google-cloud-vision/protos/protos.json b/packages/google-cloud-vision/protos/protos.json
@@ -9017,34 +9017,41 @@
               "extend": "google.protobuf.MethodOptions"
             },
             "Operations": {
+              "options": {
+                "(google.api.default_host)": "longrunning.googleapis.com"
+              },
               "methods": {
                 "ListOperations": {
                   "requestType": "ListOperationsRequest",
                   "responseType": "ListOperationsResponse",
                   "options": {
-                    "(google.api.http).get": "/v1/{name=operations}"
+                    "(google.api.http).get": "/v1/{name=operations}",
+                    "(google.api.method_signature)": "name,filter"
                   }
                 },
                 "GetOperation": {
                   "requestType": "GetOperationRequest",
                   "responseType": "Operation",
                   "options": {
-                    "(google.api.http).get": "/v1/{name=operations/**}"
+                    "(google.api.http).get": "/v1/{name=operations/**}",
+                    "(google.api.method_signature)": "name"
                   }
                 },
                 "DeleteOperation": {
                   "requestType": "DeleteOperationRequest",
                   "responseType": "google.protobuf.Empty",
                   "options": {
-                    "(google.api.http).delete": "/v1/{name=operations/**}"
+                    "(google.api.http).delete": "/v1/{name=operations/**}",
+                    "(google.api.method_signature)": "name"
                   }
                 },
                 "CancelOperation": {
                   "requestType": "CancelOperationRequest",
                   "responseType": "google.protobuf.Empty",
                   "options": {
                     "(google.api.http).post": "/v1/{name=operations/**}:cancel",
-                    "(google.api.http).body": "*"
+                    "(google.api.http).body": "*",
+                    "(google.api.method_signature)": "name"
                   }
                 },
                 "WaitOperation": {
@@ -9170,6 +9177,7 @@
         },
         "rpc": {
           "options": {
+            "cc_enable_arenas": true,
             "go_package": "google.golang.org/genproto/googleapis/rpc/status;status",
             "java_multiple_files": true,
             "java_outer_classname": "StatusProto",

diff --git a/packages/google-cloud-vision/synth.metadata b/packages/google-cloud-vision/synth.metadata
@@ -1,5 +1,22 @@
 {
-  "updateTime": "2020-03-31T20:16:47.942825Z",
+  "updateTime": "2020-04-10T20:00:59.209374Z",
+  "sources": [
+    {
+      "git": {
+        "name": "googleapis",
+        "remote": "https://github.com/googleapis/googleapis.git",
+        "sha": "cf18ab5200e41e9d0cfef88c6c4bcdd394faf1ca",
+        "internalRef": "305925954"
+      }
+    },
+    {
+      "git": {
+        "name": "synthtool",
+        "remote": "https://github.com/googleapis/synthtool.git",
+        "sha": "6f32150677c9784f3c3a7e1949472bd29c9d72c5"
+      }
+    }
+  ],
   "destinations": [
     {
       "client": {

diff --git a/packages/google-cloud-vision/synth.py b/packages/google-cloud-vision/synth.py
@@ -43,7 +43,9 @@
 for version in versions:
     client_file = f"src/{version}/image_annotator_client.ts"
     s.replace(client_file, '\Z',
-    'import {FeaturesMethod} from \'../helpers\'; \n export interface ImageAnnotatorClient extends FeaturesMethod {}'
+    'import {FeaturesMethod} from \'../helpers\';\n' +
+    '// eslint-disable-next-line @typescript-eslint/no-empty-interface\n' +
+    'export interface ImageAnnotatorClient extends FeaturesMethod {}\n'
     )
 # Copy common templates
 common_templates = gcp.CommonTemplates()

diff --git a/packages/google-cloud-vision/system-test/vision.ts b/packages/google-cloud-vision/system-test/vision.ts
@@ -20,7 +20,7 @@ import {Storage} from '@google-cloud/storage';
 import * as uuid from 'uuid';
 import * as prototypes from '../protos/protos';
 import * as vision from '../src';
-// const vision = require('../src');
+
 describe('Vision', () => {
   const IMAGES = Object.freeze({
     document: path.join(

diff --git a/packages/google-cloud-vision/test/gapic_image_annotator_v1.ts b/packages/google-cloud-vision/test/gapic_image_annotator_v1.ts
@@ -270,7 +270,7 @@ describe('v1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.batchAnnotateImages(request);
       }, expectedError);
       assert(
@@ -386,7 +386,7 @@ describe('v1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.batchAnnotateFiles(request);
       }, expectedError);
       assert(
@@ -510,7 +510,7 @@ describe('v1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.asyncBatchAnnotateImages(request);
       }, expectedError);
       assert(
@@ -545,7 +545,7 @@ describe('v1.ImageAnnotatorClient', () => {
         expectedError
       );
       const [operation] = await client.asyncBatchAnnotateImages(request);
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await operation.promise();
       }, expectedError);
       assert(
@@ -669,7 +669,7 @@ describe('v1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.asyncBatchAnnotateFiles(request);
       }, expectedError);
       assert(
@@ -704,7 +704,7 @@ describe('v1.ImageAnnotatorClient', () => {
         expectedError
       );
       const [operation] = await client.asyncBatchAnnotateFiles(request);
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await operation.promise();
       }, expectedError);
       assert(

diff --git a/packages/google-cloud-vision/test/gapic_image_annotator_v1p1beta1.ts b/packages/google-cloud-vision/test/gapic_image_annotator_v1p1beta1.ts
@@ -214,7 +214,7 @@ describe('v1p1beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.batchAnnotateImages(request);
       }, expectedError);
       assert(

diff --git a/packages/google-cloud-vision/test/gapic_image_annotator_v1p2beta1.ts b/packages/google-cloud-vision/test/gapic_image_annotator_v1p2beta1.ts
@@ -246,7 +246,7 @@ describe('v1p2beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.batchAnnotateImages(request);
       }, expectedError);
       assert(
@@ -346,7 +346,7 @@ describe('v1p2beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.asyncBatchAnnotateFiles(request);
       }, expectedError);
       assert(
@@ -373,7 +373,7 @@ describe('v1p2beta1.ImageAnnotatorClient', () => {
         expectedError
       );
       const [operation] = await client.asyncBatchAnnotateFiles(request);
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await operation.promise();
       }, expectedError);
       assert(

diff --git a/packages/google-cloud-vision/test/gapic_image_annotator_v1p3beta1.ts b/packages/google-cloud-vision/test/gapic_image_annotator_v1p3beta1.ts
@@ -246,7 +246,7 @@ describe('v1p3beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.batchAnnotateImages(request);
       }, expectedError);
       assert(
@@ -346,7 +346,7 @@ describe('v1p3beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.asyncBatchAnnotateFiles(request);
       }, expectedError);
       assert(
@@ -373,7 +373,7 @@ describe('v1p3beta1.ImageAnnotatorClient', () => {
         expectedError
       );
       const [operation] = await client.asyncBatchAnnotateFiles(request);
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await operation.promise();
       }, expectedError);
       assert(

diff --git a/packages/google-cloud-vision/test/gapic_image_annotator_v1p4beta1.ts b/packages/google-cloud-vision/test/gapic_image_annotator_v1p4beta1.ts
@@ -246,7 +246,7 @@ describe('v1p4beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.batchAnnotateImages(request);
       }, expectedError);
       assert(
@@ -338,7 +338,7 @@ describe('v1p4beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.batchAnnotateFiles(request);
       }, expectedError);
       assert(
@@ -438,7 +438,7 @@ describe('v1p4beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.asyncBatchAnnotateImages(request);
       }, expectedError);
       assert(
@@ -465,7 +465,7 @@ describe('v1p4beta1.ImageAnnotatorClient', () => {
         expectedError
       );
       const [operation] = await client.asyncBatchAnnotateImages(request);
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await operation.promise();
       }, expectedError);
       assert(
@@ -565,7 +565,7 @@ describe('v1p4beta1.ImageAnnotatorClient', () => {
         undefined,
         expectedError
       );
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await client.asyncBatchAnnotateFiles(request);
       }, expectedError);
       assert(
@@ -592,7 +592,7 @@ describe('v1p4beta1.ImageAnnotatorClient', () => {
         expectedError
       );
       const [operation] = await client.asyncBatchAnnotateFiles(request);
-      assert.rejects(async () => {
+      await assert.rejects(async () => {
         await operation.promise();
       }, expectedError);
       assert(