Merge pull request #23 from silvolu/master

Fix pagination for queries with offset.
googleapis · Jul 21, 2014 · ffcf2d2 · ffcf2d2
2 parents bb7a70a + ad9626e
commit ffcf2d2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/lib/datastore/query.js b/lib/datastore/query.js
@@ -76,6 +76,7 @@ Query.prototype.select = function(fieldNames) {
 Query.prototype.start = function(start) {
   var q = util.extend(this, new Query());
   q.startVal = start;
+  q.offsetVal = 0;
   return q;
 }
 

diff --git a/test/datastore.query.js b/test/datastore.query.js
@@ -112,6 +112,13 @@ describe('Query', function() {
     done();
   });
 
+  it('should reset the offset to 0 when using start tokens', function(done) {
+    var q = ds.createQuery(['kind1']).offset(5);
+    q.start('startVal');
+    assert.strictEqual(q.offsetVal, 0);
+    done();
+  });
+
   it('should be converted to a query proto successfully', function(done) {
     var q = ds.createQuery(['Kind'])
         .select(['name', 'count'])