Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storage ACL helper methods have not been promisified #1813

Closed
jmdobry opened this issue Nov 22, 2016 · 0 comments
Closed

Storage ACL helper methods have not been promisified #1813

jmdobry opened this issue Nov 22, 2016 · 0 comments
Assignees
@stephenplusplus
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jmdobry
Copy link
Contributor

jmdobry commented Nov 22, 2016

e.g.

// throws "Uncaught TypeError: callback is not a function"
bucket.acl.readers.addUser('foo@test.com')
  .then(() => {});
@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Nov 22, 2016
This was referenced Nov 22, 2016
Merged
Merged
@takeratta takeratta mentioned this issue Jul 6, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stephenplusplus @jmdobry