Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promisify Storage ACL methods #1814

Merged
merged 3 commits into from
Nov 30, 2016
Merged

promisify Storage ACL methods #1814

merged 3 commits into from
Nov 30, 2016

Conversation

jmdobry
Copy link
Contributor

@jmdobry jmdobry commented Nov 22, 2016 •
edited by stephenplusplus
Loading

Fixes #1813

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2016
@stephenplusplus stephenplusplus changed the title Fixes #1813 promisify Storage ACL methods Nov 22, 2016
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 29, 2016
@callmehiphop
Copy link
Contributor

@jmdobry I don't think we need to re-promisify here, so I added a commit with a different solution. PTAL!

@stephenplusplus stephenplusplus added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Nov 29, 2016
jmdobry
jmdobry commented Nov 29, 2016
View reviewed changes
Copy link
Contributor Author

@jmdobry jmdobry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution appears to work. LGTM

@callmehiphop
Copy link
Contributor

@stephenplusplus PTAL

@stephenplusplus stephenplusplus merged commit 66e9ae5 into googleapis:master Nov 30, 2016
@jmdobry jmdobry deleted the storage-acl-promise branch November 30, 2016 18:44
@jmdobry
Copy link
Contributor Author

jmdobry commented Dec 7, 2016

Any ETA on when this will get released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stephenplusplus stephenplusplus

Labels
api: storage Issues related to the Cloud Storage API. cla: no This human has *not* signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmdobry @googlebot @callmehiphop @stephenplusplus