Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change download link to not require storage.getMetadata() ? #524

Closed
jgeewax opened this issue May 4, 2015 · 0 comments
Closed

Change download link to not require storage.getMetadata() ? #524

jgeewax opened this issue May 4, 2015 · 0 comments
Assignees
@stephenplusplus
Labels
api: storage Issues related to the Cloud Storage API.
Milestone
Storage Stable

Comments

@jgeewax
Copy link
Contributor

jgeewax commented May 4, 2015

Looks like we can auto-generate the download link without pulling all the metadata in a separate request:

https://<bucket>.storage.googleapis.com/<object>

Can we just make this a standard URL?

@robertdimarco says:

Remove the getMetadata() round-trip from the createReadStream() code path, in the interests of reducing overall request latency.

In comparison to the S3 implementation we were using, gcloud-node performs an additional call to the storage backend in series to get the metadata to obtain a download link. This download link, however, is able to be statically generated. Removing the extra round-trip to the server would halve the request latency for serving small files.
@jgeewax jgeewax added enhancement api: storage Issues related to the Cloud Storage API. labels May 4, 2015
@jgeewax jgeewax added this to the Storage Stable milestone May 4, 2015
@stephenplusplus stephenplusplus self-assigned this May 4, 2015
stephenplusplus added a commit to stephenplusplus/gcloud-node that referenced this issue May 4, 2015
@stephenplusplus
storage: use standard URL instead of calling getMetadata - fixes goog…
f79550b 
…leapis#524
@stephenplusplus stephenplusplus mentioned this issue May 4, 2015
Merged
ryanseys added a commit that referenced this issue May 4, 2015
@ryanseys
Merge pull request #525 from stephenplusplus/spp--storage-change-down…
98a2153 
…load-link

storage: use standard URL instead of calling getMetadata - fixes #524
@robertdimarco robertdimarco mentioned this issue May 19, 2015
Closed
@snyk-bot snyk-bot mentioned this issue Jan 29, 2022
Open
@mikolajroszak mikolajroszak mentioned this issue May 7, 2022
Open
@sofisl sofisl mentioned this issue Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Sep 15, 2022
@renovate-bot
chore(deps): update dependency sinon to v12 (#524)
d7c8a6d 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [sinon](https://sinonjs.org/) ([source](https://togithub.com/sinonjs/sinon)) | [`^11.0.0` -> `^12.0.0`](https://renovatebot.com/diffs/npm/sinon/11.1.2/12.0.1) | [![age](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/compatibility-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/sinon/12.0.1/confidence-slim/11.1.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>sinonjs/sinon</summary>

### [`v12.0.1`](https://togithub.com/sinonjs/sinon/blob/master/CHANGES.md#&#8203;1201)

[Compare Source](https://togithub.com/sinonjs/sinon/compare/v12.0.0...v12.0.1)

-   [`3f598221`](https://togithub.com/sinonjs/sinon/commit/3f598221045904681f2b3b3ba1df617ed5e230e3)
    Fix issue with npm unlink for npm version > 6 (Carl-Erik Kopseng)
    > 'npm unlink' would implicitly unlink the current dir
    > until version 7, which requires an argument
-   [`51417a38`](https://togithub.com/sinonjs/sinon/commit/51417a38111eeeb7cd14338bfb762cc2df487e1b)
    Fix bundling of cjs module ([#&#8203;2412](https://togithub.com/sinonjs/sinon/issues/2412)) (Julian Grinblat)
    > -   Fix bundling of cjs module
    >
    > -   Run prettier

*Released by [Carl-Erik Kopseng](https://togithub.com/fatso83) on 2021-11-04.*

#### 12.0.0

### [`v12.0.0`](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0)

[Compare Source](https://togithub.com/sinonjs/sinon/compare/v11.1.2...v12.0.0)

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-redis).
@sofisl sofisl mentioned this issue Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 11, 2022
@yoshi-automation
docs: updated code of conduct (includes update to actions) (#524)
ce2776e 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/87546435-a6be-41b1-b439-16b7d6c5df65/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@89c849b
Source-Link: googleapis/synthtool@a783321
Source-Link: googleapis/synthtool@b7413d3
Source-Link: googleapis/synthtool@5f6ef0e
sofisl pushed a commit that referenced this issue Oct 13, 2022
@yoshi-automation @sofisl
docs: updated code of conduct (includes update to actions) (#524)
9d17fb2 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/87546435-a6be-41b1-b439-16b7d6c5df65/targets

- [ ] To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@89c849b
Source-Link: googleapis/synthtool@a783321
Source-Link: googleapis/synthtool@b7413d3
Source-Link: googleapis/synthtool@5f6ef0e
sofisl pushed a commit that referenced this issue Nov 11, 2022
@bcoe
fix(deps): google-gax v2.24.1 (#524)
a633c4d
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 2.4.4 (#522)
b374899 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.4.4](https://www.github.com/googleapis/nodejs-dataproc/compare/v2.4.3...v2.4.4) (2021-08-17)


### Bug Fixes

* **build:** migrate to using main branch ([#523](https://www.github.com/googleapis/nodejs-dataproc/issues/523)) ([42b4163](https://www.github.com/googleapis/nodejs-dataproc/commit/42b4163483409a29740878f95cabf2ce617bfa86))
* **deps:** google-gax v2.24.1 ([#524](https://www.github.com/googleapis/nodejs-dataproc/issues/524)) ([fa82a3a](https://www.github.com/googleapis/nodejs-dataproc/commit/fa82a3a8864de5f88ce4d28445cdc85837413ee3))
* **deps:** require google-gax v2.17.1 ([#510](https://www.github.com/googleapis/nodejs-dataproc/issues/510)) ([4706b61](https://www.github.com/googleapis/nodejs-dataproc/commit/4706b61bf928f0c6e7a2c811ff203d82da8fa2a1))
* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#511](https://www.github.com/googleapis/nodejs-dataproc/issues/511)) ([be8cecc](https://www.github.com/googleapis/nodejs-dataproc/commit/be8ceccc36ffa198f983b78ae7918af43d291f42))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: update v2.14.2 gapic-generator-typescript (#524)
e3aa36b 
- [ ] Regenerate this pull request now.

Committer: @summer-ji-eng
PiperOrigin-RevId: 434859890

Source-Link: googleapis/googleapis@bc2432d

Source-Link: googleapis/googleapis-gen@930b673
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTMwYjY3MzEwM2U5MjUyM2Y4Y2ZlZDM4ZGVjZDdkM2FmYWU4ZWJlNyJ9
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore: release 2.3.0 (#524)
89861dc 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@renovate-bot
chore(deps): update dependency gts to v3 (#524)
434d65d 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [gts](https://togithub.com/google/gts) | [`^2.0.0` -> `^3.0.0`](https://renovatebot.com/diffs/npm/gts/2.0.2/3.1.0) | [![age](https://badges.renovateapi.com/packages/npm/gts/3.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/gts/3.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/gts/3.1.0/compatibility-slim/2.0.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/gts/3.1.0/confidence-slim/2.0.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>google/gts</summary>

### [`v3.1.0`](https://togithub.com/google/gts/blob/HEAD/CHANGELOG.md#&#8203;310-httpswwwgithubcomgooglegtscomparev303v310-2021-01-11)

[Compare Source](https://togithub.com/google/gts/compare/v3.0.3...v3.1.0)

##### Features

-   support comments in JSON ([#&#8203;571](https://www.togithub.com/google/gts/issues/571)) ([cb6d2ca](https://www.github.com/google/gts/commit/cb6d2cacb5de7bcc9c8e82dd47e14fc5bf9596a3))

##### Bug Fixes

-   **deps:** update dependency eslint-config-prettier to v7 ([#&#8203;601](https://www.togithub.com/google/gts/issues/601)) ([6e26681](https://www.github.com/google/gts/commit/6e266812da4b90b18e2abead9b2b5a1ca0c6654b))
-   **deps:** upgrade to latest version of meow ([#&#8203;616](https://www.togithub.com/google/gts/issues/616)) ([634bad9](https://www.github.com/google/gts/commit/634bad9bbbdb4d397bba101dc38ab14881172a30))

##### [3.0.3](https://www.github.com/google/gts/compare/v3.0.2...v3.0.3) (2020-12-03)

##### Bug Fixes

-   **deps:** update dependency execa to v5 ([#&#8203;600](https://www.togithub.com/google/gts/issues/600)) ([4e5f1e5](https://www.github.com/google/gts/commit/4e5f1e54facf53588bbb3b025b5240edbd7f3c8a))
-   **deps:** update dependency meow to v8 ([#&#8203;591](https://www.togithub.com/google/gts/issues/591)) ([c7e223e](https://www.github.com/google/gts/commit/c7e223e6a2ff605fabad2f8359a0385033f8de66))

##### [3.0.2](https://www.github.com/google/gts/compare/v3.0.1...v3.0.2) (2020-10-26)

##### Bug Fixes

-   **deps:** loosen ts peer dependency ([#&#8203;589](https://www.togithub.com/google/gts/issues/589)) ([8f1d381](https://www.github.com/google/gts/commit/8f1d381d7b166a510c42786c4a337e81b7222c84))

##### [3.0.1](https://www.github.com/google/gts/compare/v3.0.0...v3.0.1) (2020-10-12)

##### Bug Fixes

-   **rule:** turn off [@&#8203;typescript-eslint/no-var-requires](https://togithub.com/typescript-eslint/no-var-requires) ([#&#8203;578](https://www.togithub.com/google/gts/issues/578)) ([3b37229](https://www.github.com/google/gts/commit/3b37229c45969a3c53af123c69bb749578ee6b0b))

### [`v3.0.3`](https://togithub.com/google/gts/blob/HEAD/CHANGELOG.md#&#8203;303-httpswwwgithubcomgooglegtscomparev302v303-2020-12-03)

[Compare Source](https://togithub.com/google/gts/compare/v3.0.2...v3.0.3)

### [`v3.0.2`](https://togithub.com/google/gts/blob/HEAD/CHANGELOG.md#&#8203;302-httpswwwgithubcomgooglegtscomparev301v302-2020-10-26)

[Compare Source](https://togithub.com/google/gts/compare/v3.0.1...v3.0.2)

### [`v3.0.1`](https://togithub.com/google/gts/blob/HEAD/CHANGELOG.md#&#8203;301-httpswwwgithubcomgooglegtscomparev300v301-2020-10-12)

[Compare Source](https://togithub.com/google/gts/compare/v3.0.0...v3.0.1)

### [`v3.0.0`](https://togithub.com/google/gts/blob/HEAD/CHANGELOG.md#&#8203;300-httpswwwgithubcomgooglegtscomparev202v300-2020-10-08)

[Compare Source](https://togithub.com/google/gts/compare/v2.0.2...v3.0.0)

##### ⚠ BREAKING CHANGES

-   change default `check` to `lint` ([#&#8203;570](https://togithub.com/google/gts/issues/570))
-   **deps:** require TypeScript 4.x ([#&#8203;565](https://togithub.com/google/gts/issues/565))

##### Features

-   Add TypeScript v4 support ([#&#8203;551](https://www.togithub.com/google/gts/issues/551)) ([0883956](https://www.github.com/google/gts/commit/08839565a1d2b4b39d532c9b0b596f01b18856fe))
-   change default `check` to `lint` ([#&#8203;570](https://www.togithub.com/google/gts/issues/570)) ([c527b66](https://www.github.com/google/gts/commit/c527b66be1ef6a78ea14b3d29225a8d7fb7097bd))
-   generate .eslintignore when running init ([#&#8203;521](https://www.togithub.com/google/gts/issues/521)) ([8bce036](https://www.github.com/google/gts/commit/8bce0368767f0c2ad7d0700deb839962bc928d16))

##### Bug Fixes

-   add build/.eslintrc.json to files field ([#&#8203;553](https://www.togithub.com/google/gts/issues/553)) ([3b516ad](https://www.github.com/google/gts/commit/3b516ad5e9f0d58201dde469461db7c6ed1c1b78))
-   **deps:** require TypeScript 4.x ([#&#8203;565](https://www.togithub.com/google/gts/issues/565)) ([cbc5267](https://www.github.com/google/gts/commit/cbc5267579ef24e8c8ceaa2ef794df3ef54ea56a))
-   **deps:** update dependency update-notifier to v5 ([#&#8203;574](https://www.togithub.com/google/gts/issues/574)) ([9a882bf](https://www.github.com/google/gts/commit/9a882bf4ac30ad06e7b91a65ad5721d8e8b41c4b))
-   **deps:** update typescript-eslint monorepo to v2.34.0 ([#&#8203;509](https://www.togithub.com/google/gts/issues/509)) ([998a4ac](https://www.github.com/google/gts/commit/998a4ac9b75c97f04d8e5db37563f32d31652f23))
-   **deps:** update typescript-eslint monorepo to v3 (major) ([#&#8203;528](https://www.togithub.com/google/gts/issues/528)) ([e22e173](https://www.github.com/google/gts/commit/e22e17338db2ddb7eb829c821037c2f4e77ff869))
-   **deps:** update typescript-eslint monorepo to v4 ([#&#8203;556](https://www.togithub.com/google/gts/issues/556)) ([54148df](https://www.github.com/google/gts/commit/54148dfbd8b5f8b36a0f44f901c5db933393a661))
-   better error message for broken tsconfig.json ([#&#8203;501](https://www.togithub.com/google/gts/issues/501)) ([0c17a76](https://www.github.com/google/gts/commit/0c17a76c6650eee1d8abaff11a897a432eeaa65f))
-   prohibit calls for it.only and describe.only ([#&#8203;499](https://www.togithub.com/google/gts/issues/499)) ([071c33c](https://www.github.com/google/gts/commit/071c33ceef0e3765166aaebf6ed4698167ac0f98))

##### [2.0.2](https://www.github.com/google/gts/compare/v2.0.1...v2.0.2) (2020-05-11)

##### Bug Fixes

-   Revert 'update dependency eslint to v7'" ([#&#8203;507](https://www.togithub.com/google/gts/issues/507)) ([0f9950b](https://www.github.com/google/gts/commit/0f9950b273329dbcce5f3cc20864c3dcd076f08c))
-   **deps:** pin release of eslint-typescript ([#&#8203;508](https://www.togithub.com/google/gts/issues/508)) ([bd86b42](https://www.github.com/google/gts/commit/bd86b42e2bb904d3765dee82262e4691a11b9958))
-   **deps:** update dependency eslint to v7 ([#&#8203;504](https://www.togithub.com/google/gts/issues/504)) ([6aee159](https://www.github.com/google/gts/commit/6aee1595d0486ae2c7fd68d16b1b59c4c4015753))

##### [2.0.1](https://www.github.com/google/gts/compare/v2.0.0...v2.0.1) (2020-05-07)

##### Bug Fixes

-   throw an error if running with an unsupported version of nodejs ([#&#8203;493](https://www.togithub.com/google/gts/issues/493)) ([94fdf1e](https://www.github.com/google/gts/commit/94fdf1eaed634aa73c3e44c7a3d9f1325f773b07))
-   **deps:** update dependency meow to v7 ([#&#8203;502](https://www.togithub.com/google/gts/issues/502)) ([cf91cda](https://www.github.com/google/gts/commit/cf91cda1afab25759427511d3c97d0037d61c649))

</details>

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-kms).
sofisl pushed a commit that referenced this issue Nov 17, 2022
@release-please
chore: release 2.4.1 (#524)
0d3d43b 
🤖 I have created a release \*beep\* \*boop\* 
---
### [2.4.1](https://www.github.com/googleapis/nodejs-compute/compare/v2.4.0...v2.4.1) (2020-11-25)


### Bug Fixes

* skip tests for now ([#523](https://www.github.com/googleapis/nodejs-compute/issues/523)) ([f0f8fae](https://www.github.com/googleapis/nodejs-compute/commit/f0f8faee962b5463b26c7551adae67a724875a55))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
@sofisl sofisl mentioned this issue Nov 17, 2022
Merged
4 tasks
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@yoshi-automation
build: use gapic-generator-typescript v1.0.7. (#524)
0cfaadc 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/5f7f9c6d-c75a-4c60-8bb8-0026a14cead7/targets

- [ ] To automatically regenerate this PR, check this box.

PiperOrigin-RevId: 325949033
Source-Link: googleapis/googleapis@94006b3
@sofisl sofisl mentioned this issue Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 13, 2023
@bcoe @JustinBeckwith
fix(deps): require google-gax v2.17.0 (#524)
ad278bb 
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
sofisl pushed a commit that referenced this issue Sep 13, 2023
@release-please
chore: release 2.4.3 (#520)
b341a03 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.4.3](https://www.github.com/googleapis/nodejs-automl/compare/v2.4.2...v2.4.3) (2021-07-21)


### Bug Fixes

* **deps:** google-gax v2.17.1 ([#526](https://www.github.com/googleapis/nodejs-automl/issues/526)) ([8911d45](https://www.github.com/googleapis/nodejs-automl/commit/8911d457513f2c0c9cca6d2b7473b314ac3a4efd))
* **deps:** require google-gax v2.17.0 ([#524](https://www.github.com/googleapis/nodejs-automl/issues/524)) ([5863c54](https://www.github.com/googleapis/nodejs-automl/commit/5863c5440bf94fa2fd986b5c8f5265b86fd4497e))
* make request optional in all cases ([#521](https://www.github.com/googleapis/nodejs-automl/issues/521)) ([a45622a](https://www.github.com/googleapis/nodejs-automl/commit/a45622a9f53683a73fd2057ef5a2ccf22e7da946))
* REST fallback client header ([#513](https://www.github.com/googleapis/nodejs-automl/issues/513)) ([833d2d7](https://www.github.com/googleapis/nodejs-automl/commit/833d2d70ff1828a69e7f9482f58189f5d484751f))
* Updating WORKSPACE files to use the newest version of the Typescript generator. ([#527](https://www.github.com/googleapis/nodejs-automl/issues/527)) ([dfb504e](https://www.github.com/googleapis/nodejs-automl/commit/dfb504e12075136707e5915b1db6f65ed72d5aa9))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
sofisl added a commit that referenced this issue Sep 14, 2023
@sofisl
build!: update library to use Node 12 (#524)
7341476 
* build!: Update library to use Node 12
Co-authored-by: Summer Ji <summerji@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephenplusplus stephenplusplus

Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
Storage Stable
Development

No branches or pull requests
2 participants
@jgeewax @stephenplusplus