Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list what arguments go into the callback #628

Closed
jgeewax opened this issue May 26, 2015 · 1 comment
Closed

list what arguments go into the callback #628

jgeewax opened this issue May 26, 2015 · 1 comment
Assignees
@callmehiphop
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone
Core Stable

Comments

@jgeewax
Copy link
Contributor

jgeewax commented May 26, 2015

I think this is actually a more widely spread problem, where the examples have been saving us, but...

Is there any way we could more broadly document the arguments that go into the callback function?
@jgeewax jgeewax added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. docs labels May 26, 2015
@jgeewax jgeewax added this to the Storage Stable milestone May 26, 2015
@stephenplusplus
Copy link
Contributor

Yeah, I think that'd be great to document 👍

@stephenplusplus stephenplusplus changed the title gcloud.storage.createBucket documentation doesn't say what arguments go into the callback list what arguments go into the callback Jun 17, 2015
@callmehiphop callmehiphop self-assigned this Jul 23, 2015
@callmehiphop callmehiphop mentioned this issue Jul 23, 2015
Merged
6 tasks
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@alexander-fenster
test: increase sample test timeout (#628)
c8bc91d
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@alexander-fenster
test: increase sample test timeout (#628)
6ab1db0
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@alexander-fenster
test: increase sample test timeout (#628)
244a073
@sofisl sofisl mentioned this issue Sep 27, 2022
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 27, 2022
@renovate-bot @gcf-merge-on-green @bcoe
chore(deps): update dependency sinon to v12 (#628)
9229e18 
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
@sofisl sofisl mentioned this issue Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 11, 2022
@renovate-bot
chore(deps): update dependency @types/node to v16 (#628)
42c5994 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/compatibility-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/confidence-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-language).
sofisl pushed a commit that referenced this issue Oct 13, 2022
@renovate-bot @sofisl
chore(deps): update dependency @types/node to v16 (#628)
506d5bb 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.0.0` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/compatibility-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/confidence-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-language).
sofisl pushed a commit that referenced this issue Nov 9, 2022
@renovate-bot @gcf-merge-on-green @bcoe
chore(deps): update dependency sinon to v12 (#628)
4c5c55b 
Co-authored-by: gcf-merge-on-green[bot] <60162190+gcf-merge-on-green[bot]@users.noreply.github.com>
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
This was referenced Nov 9, 2022
Closed
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: override API mixins when needed (#628)
2ac64e3 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 477248447

Source-Link: googleapis/googleapis@4689c73

Source-Link: googleapis/googleapis-gen@c405978
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQwNTk3ODZhNWNkODA1YTAxNTFkOTViNDc3ZmJjNDg2YmNiY2VkYyJ9

chore: updated docs and code sturcture for Dataproc metric configuration
Committer: @akshatbhargava123
PiperOrigin-RevId: 477101789

Source-Link: googleapis/googleapis@2e19de1

Source-Link: googleapis/googleapis-gen@c12032a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzEyMDMyYTU5Nzc4ZmRkMTczZDRjZmU4MmM0NzJjMDU5NjA0Mzg2NSJ9
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@release-please
chore(main): release 3.0.2 (#628)
ebcaa5c 
🤖 I have created a release *beep* *boop*
---


## [3.0.2](googleapis/nodejs-monitoring@v3.0.1...v3.0.2) (2022-09-09)


### Bug Fixes

* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-monitoring/issues/1553)) ([#627](googleapis/nodejs-monitoring#627)) ([647e8ab](googleapis/nodejs-monitoring@647e8ab))
* use google-gax v3.3.0 ([647e8ab](googleapis/nodejs-monitoring@647e8ab))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Nov 11, 2022
@alexander-fenster
test: increase sample test timeout (#628)
ac58a71
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
@takeratta takeratta mentioned this issue Jul 6, 2023
Open
@sofisl sofisl mentioned this issue Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 13, 2023
@gcf-owl-bot
fix: do not import the whole google-gax from proto JS (#1553) (#628)
313c7ef 
fix: use google-gax v3.3.0
Source-Link: googleapis/synthtool@c73d112
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:b15a6f06cc06dcffa11e1bebdf1a74b6775a134aac24a0f86f51ddf728eb373e
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
@takeratta takeratta mentioned this issue Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@callmehiphop callmehiphop

Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
Core Stable
Development

No branches or pull requests
3 participants
@jgeewax @stephenplusplus @callmehiphop