Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross-namespace kind metadata #86

Closed
pcostell opened this issue Aug 1, 2014 · 11 comments
Closed

cross-namespace kind metadata #86

pcostell opened this issue Aug 1, 2014 · 11 comments
Assignees
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@pcostell
Copy link
Contributor

pcostell commented Aug 1, 2014

When a user registers a kind, they must also specify a namespace. My understanding of namespace usage is that most people use it to separate customer/user data. However in this case, you'd want to have dynamic namespaces for each customer, but the information about your kinds would want shared across all namespaces, since you are running the same application for each customer.

In this case, you would want to specify the namespace of a specific key/entity when you do the get/put, since this is the point where you know which customers data you are working with.

@rakyll
Copy link
Contributor

rakyll commented Aug 5, 2014

We should allow registration of kinds globally by default, and allow them to optionally override type schema for a given set of namespaces.

stephenplusplus pushed a commit to stephenplusplus/gcloud-node that referenced this issue Aug 30, 2014
@stephenplusplus stephenplusplus changed the title datastore: cross-namespace kind metadata cross-namespace kind metadata Jan 20, 2015
@stephenplusplus stephenplusplus added the api: datastore Issues related to the Datastore API. label Jan 20, 2015
@ryanseys
Copy link
Contributor

Sorry, I don't understand this issue. Could you provide an example? Perhaps with some (psuedo)code that explains essentially what is happening now vs. what would be better to happen?

@jgeewax jgeewax added this to the Datastore Stable milestone Feb 2, 2015
@pcostell
Copy link
Contributor Author

pcostell commented Feb 2, 2015

From the example:

registerKind('namespace', 'Author', {
   name: { kind: String, indexed: false },
   tags: { kind: String, multi: true }, // an array of string elements.
   favArticles: { kind: KEY, multi: true },
     contact: {
       kind: {
         telephone: { kind: String },
         email: { kind: String }
      }
   }
});

Preferred method:

registerKind('Author', {
   name: { kind: String, indexed: false },
   tags: { kind: String, multi: true }, // an array of string elements.
   favArticles: { kind: KEY, multi: true },
     contact: {
       kind: {
         telephone: { kind: String },
         email: { kind: String }
      }
   }
});

@pcostell
Copy link
Contributor Author

pcostell commented Feb 2, 2015

However, I'm not convinced that the gcloud API should expose this. It seems we should focus on getting gcloud to support both ndb and the simple key-value store. For users that want model definitions we should just recommend ndb.

@jgeewax
Copy link
Contributor

jgeewax commented Feb 2, 2015

We don't have this method -- moving this to Datastore Future (if at all).

@pcostell
Copy link
Contributor Author

pcostell commented Feb 2, 2015

Oops sorry for some reason I thought we were talking python...

registerKind does look like is still exists in lib/datastore/entity.js. In this case the ndb argument does not apply, but it may be worthwhile to separate the ORM code into a separate module/directory.

@jgeewax jgeewax assigned stephenplusplus and unassigned pcostell Feb 3, 2015
@jgeewax
Copy link
Contributor

jgeewax commented Feb 3, 2015

Kicking this over to @stephenplusplus to comment... Maybe we should get rid of this registerKind method? (see https://github.com/GoogleCloudPlatform/gcloud-node/blob/cdd41388c4f9b624f663bffb85f88bbae63780a8/lib/datastore/entity.js#L620)

@stephenplusplus
Copy link
Contributor

That apparently has been lingering around in the code since last May waiting for an implementation. I'll open a PR to kill it.

@ryanseys
Copy link
Contributor

ryanseys commented Feb 3, 2015

Are we killing this issue or can we better define what the requirements are for it?

@jgeewax
Copy link
Contributor

jgeewax commented Feb 4, 2015

I would agree with @pcostell that if we're going to introduce schema-like things for some sort of ORM, it should live in it's own repository (though possibly magically packaged up so that distribution is all one npm install).

I think it's certainly outside the scope of "Datastore stable" which is our focus right now.

@stephenplusplus stephenplusplus removed their assignment May 14, 2015
@stephenplusplus
Copy link
Contributor

Working on this over in: https://github.com/stephenplusplus/gcloud-datastore-schema -- please re-open this or post an issue over there if it's not the right approach (it's a WIP).

sofisl pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 11, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^14.14.32` -> `^16.0.0`](https://renovatebot.com/diffs/npm/@types%2fnode/14.17.32/16.11.6) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/compatibility-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fnode/16.11.6/confidence-slim/14.17.32)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-service-control).
sofisl pushed a commit that referenced this issue Nov 11, 2022
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@types/mocha](https://togithub.com/DefinitelyTyped/DefinitelyTyped) | [`^8.0.0` -> `^9.0.0`](https://renovatebot.com/diffs/npm/@types%2fmocha/8.2.3/9.1.1) | [![age](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/compatibility-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@types%2fmocha/9.1.1/confidence-slim/8.2.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: "after 9am and before 3pm" (UTC).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-dms).
sofisl pushed a commit that referenced this issue Nov 11, 2022
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [jsdoc-region-tag](https://togithub.com/googleapis/jsdoc-region-tag) | [`^1.0.6` -> `^2.0.0`](https://renovatebot.com/diffs/npm/jsdoc-region-tag/1.3.1/2.0.0) | [![age](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/compatibility-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/jsdoc-region-tag/2.0.0/confidence-slim/1.3.1)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/jsdoc-region-tag</summary>

### [`v2.0.0`](https://togithub.com/googleapis/jsdoc-region-tag/blob/HEAD/CHANGELOG.md#&#8203;200-httpsgithubcomgoogleapisjsdoc-region-tagcomparev131v200-2022-05-20)

[Compare Source](https://togithub.com/googleapis/jsdoc-region-tag/compare/v1.3.1...v2.0.0)

##### ⚠ BREAKING CHANGES

-   update library to use Node 12 ([#&#8203;107](https://togithub.com/googleapis/jsdoc-region-tag/issues/107))

##### Build System

-   update library to use Node 12 ([#&#8203;107](https://togithub.com/googleapis/jsdoc-region-tag/issues/107)) ([5b51796](https://togithub.com/googleapis/jsdoc-region-tag/commit/5b51796771984cf8b978990025f14faa03c19923))

##### [1.3.1](https://www.github.com/googleapis/jsdoc-region-tag/compare/v1.3.0...v1.3.1) (2021-08-11)

##### Bug Fixes

-   **build:** migrate to using main branch ([#&#8203;79](https://www.togithub.com/googleapis/jsdoc-region-tag/issues/79)) ([5050615](https://www.github.com/googleapis/jsdoc-region-tag/commit/50506150b7758592df5e389c6a5c3d82b3b20881))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 9am and before 3pm" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/nodejs-cloud-tpu).
sofisl pushed a commit that referenced this issue Nov 11, 2022
* chore(main): release 2.0.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl added a commit that referenced this issue Nov 16, 2022
* docs: Remove HTML tags from Cloud Retail API library docs

PiperOrigin-RevId: 387885619

Source-Link: googleapis/googleapis@2f9af29

Source-Link: googleapis/googleapis-gen@2d0b4b4

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/master/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: sofisl <55454395+sofisl@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Nov 18, 2022
sofisl pushed a commit that referenced this issue Jan 26, 2023
… v1beta1 protos (#86)

PiperOrigin-RevId: 360235141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

6 participants