-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: change resource argument to metadata #1666
Conversation
@zbjornson mind taking a quick look? Thanks for the idea! |
@@ -32,7 +32,7 @@ var is = require('is'); | |||
* @alias module:logging/entry | |||
* @constructor | |||
* | |||
* @param {object=|string=} resource - See a | |||
* @param {object=} metadata - See a | |||
* [Monitored Resource](https://cloud.google.com/logging/docs/api/ref_v2beta1/rest/v2beta1/MonitoredResource). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
@@ -206,22 +208,24 @@ Log.prototype.emergency = function(entry, options, callback) { | |||
* | |||
* @resource [LogEntry JSON representation]{@link https://cloud.google.com/logging/docs/api/ref_v2beta1/rest/v2beta1/LogEntry} | |||
* | |||
* @param {object=|string=} resource - See a | |||
* @param {object=} metadata - See a | |||
* [Monitored Resource](https://cloud.google.com/logging/docs/api/ref_v2beta1/rest/v2beta1/MonitoredResource). |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Don't have enough time to try it out at the moment, but the API and quick glance at the code look good. Thanks! Let me know if you want me to test before merging, but it looks straightforward enough. |
4a03638
to
f880a9f
Compare
Can we add some system tests for this? |
f880a9f
to
2e3f9b7
Compare
Yes, good idea. Added! |
Thanks for the fix. Do you know what version this will come out in -- 0.42.0 or 0.41.3? It's a breaking change and I need to update a dependency accordingly. |
RE: the comment on mlazarov/bunyan-stackdriver#6, we do follow semver. It'll be 0.42.0, although we're backed up for a while (3-7 days) trying to get promises in. It'll also release independently in |
Thanks.
Er, right -- I guess because it's pre-1.0.0 breaking changes are allowed. :) |
Pre-1.0, a minor bump signals a breaking change. |
Fixes #1348
Before
After