Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default hash to CRC32c and improve error message if MD5 requested but absent #1750

Merged
merged 2 commits into from
Oct 31, 2016
Merged

Change default hash to CRC32c and improve error message if MD5 requested but absent #1750

merged 2 commits into from
Oct 31, 2016

Conversation

zbjornson
Copy link
Contributor

First commit changes validation, fixes #1749.

Second commit improves the error message if MD5 is requested, but not present.

(Noticed that CONTRIBUTING now says to add my name to AUTHORS and CONTRIBUTORS, but looks like not many people do that -- actually supposed to do that?)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2016
@stephenplusplus
Copy link
Contributor

Thank you!

@omaray @jgeewax does this PR sound like a good idea? Also, please see the CONTRIBUTORS vs AUTHORS question above.

@stephenplusplus stephenplusplus added the api: storage Issues related to the Cloud Storage API. label Oct 25, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 25b92ba on zbjornson:default-hash-crc32c into bae25a9 on GoogleCloudPlatform:master.

@stephenplusplus stephenplusplus merged commit 56c745b into googleapis:master Oct 31, 2016
@stephenplusplus
Copy link
Contributor

Thanks for lookin' out for us as always!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor clarification of GCS data validation docs; change default hash algo?
4 participants