Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test index.js file #798

Merged

Conversation

stephenplusplus
Copy link
Contributor

Continuing from #795. (New PR because I didn't realize I was working off of the origin remote... used the just launched GitHub Desktop app... might lay off of that until I figure out how to use it.)

When a user gets a localized gcloud instance:

var gcloud = require('gcloud')(/*…*/);

They have been missing out on subclass static properties:

gcloud.storage.acl // undefined

This fixes that and adds tests.

We should do a patch release after this lands.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2015
@stephenplusplus
Copy link
Contributor Author

@callmehiphop RE: #795 (comment) let me know how this looks.

@@ -68,11 +68,11 @@ <h2 ng-if="method.name[0].toUpperCase() === method.name[0]">
<span class="view-code-link" docs-code-link></span>
</h3>
<p ng-if="method.description" ng-bind-html="method.description"></p>
<div ng-show="method.name[0].toUpperCase() === method.name[0]"
<div ng-show="method.constructor"

This comment was marked as spam.

callmehiphop added a commit that referenced this pull request Aug 13, 2015
@callmehiphop callmehiphop merged commit d4f066d into googleapis:master Aug 13, 2015
sofisl pushed a commit that referenced this pull request Nov 10, 2022
* feat: support regapic LRO

Use gapic-generator-typescript v2.15.1.

PiperOrigin-RevId: 456946341

Source-Link: googleapis/googleapis@88fd18d

Source-Link: googleapis/googleapis-gen@accfa37
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYWNjZmEzNzFmNjY3NDM5MzEzMzM1YzY0MDQyYjA2M2MxYzUzMTAyZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop*
---


## [7.0.0](googleapis/nodejs-translate@v6.3.1...v7.0.0) (2022-06-30)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#789)

### Features

* support regapic LRO ([#798](googleapis/nodejs-translate#798)) ([9f1ddc1](googleapis/nodejs-translate@9f1ddc1))


### Bug Fixes

* **deps:** update dependency @google-cloud/common to v4 ([#793](googleapis/nodejs-translate#793)) ([a2d079b](googleapis/nodejs-translate@a2d079b))
* **test:** fix language detection test ([#779](googleapis/nodejs-translate#779)) ([b6df5e2](googleapis/nodejs-translate@b6df5e2))


### Build System

* update library to use Node 12 ([#789](googleapis/nodejs-translate#789)) ([3060301](googleapis/nodejs-translate@3060301))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Jan 17, 2023
sofisl pushed a commit that referenced this pull request Jan 24, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 25, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants