datastore: properly parse HTTP responses from the API #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenplusplus
added
type: bug
googlebot
added
the
cla: yes
Closed
19 tasks
| // Unknown error. Format according to ApiError standard. | ||
| parsedResp.err = new util.ApiError({ | ||
| parsedHttpRespMessage.err = util.ApiError({ |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
force-pushed
the
spp--datastore-response-parsing
branch
from
31615c5
to
8b2bbf2
Compare
callmehiphop
added a commit
that referenced
this pull request
Oct 14, 2015
…parsing datastore: properly parse HTTP responses from the API
|
Thank you, sir! |
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910
The bug originally caught here by @electricFeel (thanks!) resulted in a re-factor, also bringing in some of the sane changes from #897 (the datastore v1beta3 upgrade).
PTAL asap, as we should get out a patch release as soon as possible.