Skip to content

Commit

Permalink
chore: add presubmit and continuous kokoro tests (#5229)
Browse files Browse the repository at this point in the history
* chore: add kokoro configs for running tests on PHP 7.4 and 8.0

* update PHP version for docs

* use php80 for continuous tests

* update kokoro to ues php 8 for docs gen

* update cs library and fix cs

* hopefully fix tests

* Revert "hopefully fix tests"

This reverts commit 60fe1387b5e1d22159f1cee001d4e1078dd3b448.

* fix tests for PHP 7.4

* Update docs.yml

* remove 8.0
  • Loading branch information
bshaffer committed Apr 21, 2022
1 parent c0a0532 commit 0529f2c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion tests/Unit/QueryResultsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ class QueryResultsTest extends TestCase
public $jobId = 'myJobId';
public $queryData = [
'jobComplete' => true,
'jobReference' => ['location' => 123],
'rows' => [
['f' => [['v' => 'Alton'], ['v' => 1]]]
],
Expand Down Expand Up @@ -203,7 +204,7 @@ public function testReloadsInfo()

public function testGetsIdentity()
{
$queryResults = $this->getQueryResults($this->connection);
$queryResults = $this->getQueryResults($this->connection, $this->queryData);

$this->assertEquals($this->jobId, $queryResults->identity()['jobId']);
$this->assertEquals($this->projectId, $queryResults->identity()['projectId']);
Expand Down

0 comments on commit 0529f2c

Please sign in to comment.