fix: Improve PHP 8.1 compatibility by disabling deprecation notices (#…

…4746)

BigQuery/src/QueryResults.php

@@ -352,6 +352,7 @@ public function job()
      *         query completion has been exceeded.
      * @throws GoogleException Thrown in the case of a malformed response.
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return $this->rows();

Bigtable/src/ChunkFormatter.php

@@ -490,6 +490,7 @@ private function cellInProgress(CellChunk $chunk)
      * @return \Generator
      * @throws BigtableDataOperationException Thrown in the case of a malformed response.
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return $this->readAll();

Bigtable/src/ResumableStream.php

@@ -112,6 +112,7 @@ public function readAll()
      * @return \Generator
      * @throws ApiException Thrown in the case of a malformed response.
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return $this->readAll();

Core/src/Iterator/ItemIteratorTrait.php

@@ -74,6 +74,7 @@ public function iterateByPage()
      *
      * @return null
      */
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         $this->pageIndex = 0;
@@ -86,6 +87,7 @@ public function rewind()
      *
      * @return mixed
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         $page = $this->pageIterator->current();
@@ -100,6 +102,7 @@ public function current()
      *
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return $this->position;
@@ -110,6 +113,7 @@ public function key()
      *
      * @return null
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         $this->pageIndex++;
@@ -126,6 +130,7 @@ public function next()
      *
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         $page = $this->pageIterator->current();

Core/src/Iterator/PageIteratorTrait.php

@@ -146,6 +146,7 @@ public function nextResultToken()
      *
      * @return null
      */
+    #[\ReturnTypeWillChange]
     public function rewind()
     {
         $this->itemCount = 0;
@@ -169,6 +170,7 @@ public function rewind()
      *
      * @return array|null
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         if ($this->page === null) {
@@ -189,6 +191,7 @@ public function current()
      *
      * @return int
      */
+    #[\ReturnTypeWillChange]
     public function key()
     {
         return $this->position;
@@ -199,6 +202,7 @@ public function key()
      *
      * @return null
      */
+    #[\ReturnTypeWillChange]
     public function next()
     {
         $this->position++;
@@ -212,6 +216,7 @@ public function next()
      *
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function valid()
     {
         if (!$this->page && $this->position) {

Core/src/Testing/FileListFilterIterator.php

@@ -62,6 +62,7 @@ public function __construct(
      * @experimental
      * @internal
      */
+    #[\ReturnTypeWillChange]
     public function accept()
     {
         /** @var \SplFileInfo */

Core/src/Testing/Snippet/Coverage/ExcludeFilter.php

@@ -44,6 +44,7 @@ public function __construct(Iterator $iterator, array $excludeDirs)
     /**
      * @return bool Determines whether to accept or exclude a path
      */
+    #[\ReturnTypeWillChange]
     public function accept()
     {
         // Accept the current item if we can recurse into it

Core/src/Testing/Snippet/Parser/Snippet.php

@@ -291,6 +291,7 @@ public function regexReplace($pattern, $new)
      *
      * @return array
      */
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->config;

Datastore/src/DatastoreSessionHandler.php

@@ -189,6 +189,7 @@ public function __construct(
      *        used here. It will use this value as the Datastore kind.
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function open($savePath, $sessionName)
     {
         $this->kind = $sessionName;
@@ -206,6 +207,7 @@ public function open($savePath, $sessionName)
     /**
      * Just return true for this implementation.
      */
+    #[\ReturnTypeWillChange]
     public function close()
     {
         return true;
@@ -214,6 +216,7 @@ public function close()
     /**
      * Read the session data from Cloud Datastore.
      */
+    #[\ReturnTypeWillChange]
     public function read($id)
     {
         try {
@@ -243,6 +246,7 @@ public function read($id)
      * @param string $data The session data to write to the {@see \Google\Cloud\Datastore\Entity}.
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function write($id, $data)
     {
         try {
@@ -274,6 +278,7 @@ public function write($id, $data)
     /**
      * Delete the session data from Cloud Datastore.
      */
+    #[\ReturnTypeWillChange]
     public function destroy($id)
     {
         try {
@@ -297,6 +302,7 @@ public function destroy($id)
     /**
      * Delete the old session data from Cloud Datastore.
      */
+    #[\ReturnTypeWillChange]
     public function gc($maxlifetime)
     {
         if ($this->gcLimit === 0) {

Datastore/src/Entity.php

@@ -113,6 +113,7 @@ class Entity implements ArrayAccess, EntityInterface
      * @return void
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($key, $val)
     {
         $this->entity[$key] = $val;
@@ -123,6 +124,7 @@ public function offsetSet($key, $val)
      * @return bool
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($key)
     {
         return isset($this->entity[$key]);
@@ -133,6 +135,7 @@ public function offsetExists($key)
      * @return void
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($key)
     {
         unset($this->entity[$key]);
@@ -143,6 +146,7 @@ public function offsetUnset($key)
      * @return mixed
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($key)
     {
         return isset($this->entity[$key])

Datastore/src/EntityPageIterator.php

@@ -51,6 +51,7 @@ public function moreResultsType()
      *
      * @return array|null
      */
+    #[\ReturnTypeWillChange]
     public function current()
     {
         if (!$this->page) {

Datastore/src/Key.php

@@ -421,6 +421,7 @@ public function keyObject()
     /**
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->keyObject();

Datastore/src/Query/GqlQuery.php

@@ -214,6 +214,7 @@ public function start($cursor)
      * @access private
      * @return array
      */
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->queryObject();

Datastore/src/Query/Query.php

@@ -476,6 +476,7 @@ public function queryKey()
     /**
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return $this->queryObject();

Datastore/tests/Unit/SampleEntity.php

@@ -33,21 +33,25 @@ public static function mappings()
         ];
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetSet($key, $val)
     {
         $this->entity[$key] = $val;
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetExists($key)
     {
         return isset($this->entity[$key]);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetUnset($key)
     {
         unset($this->entity[$key]);
     }
 
+    #[\ReturnTypeWillChange]
     public function offsetGet($key)
     {
         return isset($this->entity[$key])

Debugger/src/MatchingFileIterator.php

@@ -62,6 +62,7 @@ public function __construct($searchPath, $file)
      * @access private
      * @return boolean
      */
+    #[\ReturnTypeWillChange]
     public function accept()
     {
         $candidate = $this->getInnerIterator()->current();

Firestore/src/DocumentSnapshot.php

@@ -310,6 +310,7 @@ public function get($fieldPath)
     /**
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetSet($offset, $value)
     {
         throw new \BadMethodCallException('DocumentSnapshots are read-only.');
@@ -318,6 +319,7 @@ public function offsetSet($offset, $value)
     /**
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetExists($offset)
     {
         return array_key_exists($offset, $this->data);
@@ -326,6 +328,7 @@ public function offsetExists($offset)
     /**
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetUnset($offset)
     {
         throw new \BadMethodCallException('DocumentSnapshots are read-only.');
@@ -334,6 +337,7 @@ public function offsetUnset($offset)
     /**
      * @access private
      */
+    #[\ReturnTypeWillChange]
     public function offsetGet($offset)
     {
         if (!$this->offsetExists($offset)) {

Firestore/src/FirestoreSessionHandler.php

@@ -211,6 +211,7 @@ public function __construct(
      *        used in the Firestore collection ID.
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function open($savePath, $sessionName)
     {
         $this->savePath = $savePath;
@@ -241,6 +242,7 @@ public function open($savePath, $sessionName)
     /**
      * Close the transaction and commit any changes.
      */
+    #[\ReturnTypeWillChange]
     public function close()
     {
         if (is_null($this->transaction)) {
@@ -264,6 +266,7 @@ public function close()
      * @param string $id Identifier used for the session.
      * @return string
      */
+    #[\ReturnTypeWillChange]
     public function read($id)
     {
         $this->id = $id;
@@ -298,6 +301,7 @@ public function read($id)
      * @param string $data The session data to write to the Firestore document.
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function write($id, $data)
     {
         $docRef = $this->getDocumentReference(
@@ -320,6 +324,7 @@ public function write($id, $data)
      * @param string $id Identifier used for the session
      * @return bool
      */
+    #[\ReturnTypeWillChange]
     public function destroy($id)
     {
         $docRef = $this->getDocumentReference(
@@ -340,6 +345,7 @@ public function destroy($id)
      *        in seconds.
      * @return int|bool
      */
+    #[\ReturnTypeWillChange]
     public function gc($maxlifetime)
     {
         if (0 === $this->options['gcLimit']) {

Firestore/src/QuerySnapshot.php

@@ -112,6 +112,7 @@ public function rows()
      * @access private
      * @return \ArrayIterator
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return new \ArrayIterator($this->rows);

Spanner/src/Result.php

@@ -374,6 +374,7 @@ public function transaction()
      * @access private
      * @return \Generator
      */
+    #[\ReturnTypeWillChange]
     public function getIterator()
     {
         return $this->rows();