Update Pub/Sub generated client retry configuration. (#1675)

This PR was generated using Autosynth. 🌈 Here's the log from Synthtool: ``` synthtool > Executing /tmpfs/src/git/autosynth/working_repo/PubSub/synth.py. synthtool > Ensuring dependencies. synthtool > Pulling artman image. latest: Pulling from googleapis/artman Digest: sha256:5fd9aee1d82a00cebf425c8fa431f5457539562f5867ad9c54370f0ec9a7ccaa Status: Image is up to date for googleapis/artman:latest synthtool > Cloning googleapis. synthtool > Running generator for google/pubsub/artman_pubsub.yaml. synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-pubsub-v1. synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/PublisherGapicClient.php. synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SubscriberGapicClient.php. synthtool > Replaced 'Copyright \\d{4}' in src/V1/PublisherClient.php. synthtool > Replaced 'Copyright \\d{4}' in src/V1/PublisherGrpcClient.php. synthtool > Replaced 'Copyright \\d{4}' in src/V1/SubscriberClient.php. synthtool > Replaced 'Copyright \\d{4}' in src/V1/SubscriberGrpcClient.php. synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/PublisherClientTest.php. synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SubscriberClientTest.php. synthtool > Replaced 'Copyright \\d{4}' in tests/System/V1/PublisherSmokeTest.php. synthtool > No replacements made in src/**/*.php for pattern <a href="/pubsub/docs/, maybe replacement is not longer needed? synthtool > Cleaned up 1 temporary directories. synthtool > Wrote metadata to synth.metadata. ```
googleapis · Feb 13, 2019 · 76165e5 · 76165e5
1 parent 82f4726
commit 76165e5
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 27 deletions.
diff --git a/PubSub/src/V1/resources/publisher_client_config.json b/PubSub/src/V1/resources/publisher_client_config.json
@@ -3,11 +3,15 @@
     "google.pubsub.v1.Publisher": {
       "retry_codes": {
         "idempotent": [
-          "DEADLINE_EXCEEDED",
+          "ABORTED",
+          "UNAVAILABLE",
+          "UNKNOWN"
+        ],
+        "non_idempotent": [
           "UNAVAILABLE"
         ],
-        "non_idempotent": [],
-        "one_plus_delivery": [
+        "none": [],
+        "publish": [
           "ABORTED",
           "CANCELLED",
           "DEADLINE_EXCEEDED",
@@ -40,17 +44,17 @@
       "methods": {
         "CreateTopic": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "UpdateTopic": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "Publish": {
           "timeout_millis": 60000,
-          "retry_codes_name": "one_plus_delivery",
+          "retry_codes_name": "publish",
           "retry_params_name": "messaging",
           "bundling": {
             "element_count_threshold": 10,
@@ -77,7 +81,7 @@
         },
         "DeleteTopic": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "SetIamPolicy": {

diff --git a/PubSub/src/V1/resources/subscriber_client_config.json b/PubSub/src/V1/resources/subscriber_client_config.json
@@ -3,16 +3,14 @@
     "google.pubsub.v1.Subscriber": {
       "retry_codes": {
         "idempotent": [
-          "DEADLINE_EXCEEDED",
-          "UNAVAILABLE"
+          "ABORTED",
+          "UNAVAILABLE",
+          "UNKNOWN"
         ],
-        "pull": [
-          "DEADLINE_EXCEEDED",
-          "INTERNAL",
-          "RESOURCE_EXHAUSTED",
+        "non_idempotent": [
           "UNAVAILABLE"
         ],
-        "non_idempotent": []
+        "none": []
       },
       "retry_params": {
         "default": {
@@ -56,7 +54,7 @@
         },
         "UpdateSubscription": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "ListSubscriptions": {
@@ -66,7 +64,7 @@
         },
         "DeleteSubscription": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "ModifyAckDeadline": {
@@ -76,12 +74,12 @@
         },
         "Acknowledge": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "messaging"
         },
         "Pull": {
           "timeout_millis": 60000,
-          "retry_codes_name": "pull",
+          "retry_codes_name": "idempotent",
           "retry_params_name": "messaging"
         },
         "StreamingPull": {
@@ -99,22 +97,22 @@
         },
         "CreateSnapshot": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "UpdateSnapshot": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "DeleteSnapshot": {
           "timeout_millis": 60000,
-          "retry_codes_name": "idempotent",
+          "retry_codes_name": "non_idempotent",
           "retry_params_name": "default"
         },
         "Seek": {
           "timeout_millis": 60000,
-          "retry_codes_name": "non_idempotent",
+          "retry_codes_name": "idempotent",
           "retry_params_name": "default"
         },
         "SetIamPolicy": {

diff --git a/PubSub/synth.metadata b/PubSub/synth.metadata
@@ -1,19 +1,19 @@
 {
-  "updateTime": "2019-02-02T11:02:52.477468Z",
+  "updateTime": "2019-02-13T11:01:15.874039Z",
   "sources": [
     {
       "generator": {
         "name": "artman",
-        "version": "0.16.8",
-        "dockerImage": "googleapis/artman@sha256:75bc07ef34a1de9895c18af54dc503ed3b3f3b52e85062e3360a979d2a0741e7"
+        "version": "0.16.13",
+        "dockerImage": "googleapis/artman@sha256:5fd9aee1d82a00cebf425c8fa431f5457539562f5867ad9c54370f0ec9a7ccaa"
       }
     },
     {
       "git": {
         "name": "googleapis",
         "remote": "https://github.com/googleapis/googleapis.git",
-        "sha": "bce093dab3e65c40eb9a37efbdc960f34df6037a",
-        "internalRef": "231974277"
+        "sha": "ca61898878f0926dd9dcc68ba90764f17133efe4",
+        "internalRef": "233680013"
       }
     }
   ],