Skip to content

Commit

Permalink
feat: add CompositeKey message and composite_key field to FeatureView…
Browse files Browse the repository at this point in the history 
…DataKey (#7084)

* feat: add `point_of_contact` to `Feature` message
PiperOrigin-RevId: 609142958
Source-Link: googleapis/googleapis@cc2c8aa
Source-Link: googleapis/googleapis-gen@13e938a
Copy-Tag: eyJwIjoiQWlQbGF0Zm9ybS8uT3dsQm90LnlhbWwiLCJoIjoiMTNlOTM4YWE1OWNiZjgwNjIyOTc4YzdhMDZlZDcwZWY3NWU2ZDg3MCJ9

* feat: add CompositeKey message and composite_key field to FeatureViewDataKey
PiperOrigin-RevId: 609467767
Source-Link: googleapis/googleapis@64392a1
Source-Link: googleapis/googleapis-gen@7535266
Copy-Tag: eyJwIjoiQWlQbGF0Zm9ybS8uT3dsQm90LnlhbWwiLCJoIjoiNzUzNTI2NjEwYjk4OTQxNjA1ODkxZjhiOTdjYjk1YWI3N2VlZjYzMCJ9
  • Loading branch information
@gcf-owl-bot
gcf-owl-bot[bot] committed Feb 27, 2024
1 parent 8c73576 commit f27cfba
Show file tree
Hide file tree
Showing 9 changed files with 172 additions and 0 deletions.
Binary file modified AiPlatform/metadata/V1/Feature.php
View file
Binary file not shown.
Binary file modified AiPlatform/metadata/V1/FeatureOnlineStoreService.php
View file
Binary file not shown.
38 changes: 38 additions & 0 deletions AiPlatform/src/V1/Feature.php
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions AiPlatform/src/V1/FeatureViewDataKey.php
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

72 changes: 72 additions & 0 deletions AiPlatform/src/V1/FeatureViewDataKey/CompositeKey.php
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions AiPlatform/tests/Unit/V1/Client/FeatureRegistryServiceClientTest.php
View file
Expand Up @@ -112,12 +112,14 @@ public function createFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down Expand Up @@ -624,12 +626,14 @@ public function getFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name2);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$transport->addResponse($expectedResponse);
// Mock request
$formattedName = $gapicClient->featureName('[PROJECT]', '[LOCATION]', '[FEATURESTORE]', '[ENTITY_TYPE]', '[FEATURE]');
Expand Down Expand Up @@ -920,12 +924,14 @@ public function updateFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down Expand Up @@ -1508,12 +1514,14 @@ public function createFeatureAsyncTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down
6 changes: 6 additions & 0 deletions AiPlatform/tests/Unit/V1/Client/FeaturestoreServiceClientTest.php
View file
Expand Up @@ -529,12 +529,14 @@ public function createFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down Expand Up @@ -1494,12 +1496,14 @@ public function getFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name2);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$transport->addResponse($expectedResponse);
// Mock request
$formattedName = $gapicClient->featureName('[PROJECT]', '[LOCATION]', '[FEATURESTORE]', '[ENTITY_TYPE]', '[FEATURE]');
Expand Down Expand Up @@ -2127,12 +2131,14 @@ public function updateFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$transport->addResponse($expectedResponse);
// Mock request
$feature = new Feature();
Expand Down
6 changes: 6 additions & 0 deletions AiPlatform/tests/Unit/V1/FeatureRegistryServiceClientTest.php
View file
Expand Up @@ -97,12 +97,14 @@ public function createFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down Expand Up @@ -585,12 +587,14 @@ public function getFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name2);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$transport->addResponse($expectedResponse);
// Mock request
$formattedName = $gapicClient->featureName('[PROJECT]', '[LOCATION]', '[FEATURESTORE]', '[ENTITY_TYPE]', '[FEATURE]');
Expand Down Expand Up @@ -865,12 +869,14 @@ public function updateFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down
6 changes: 6 additions & 0 deletions AiPlatform/tests/Unit/V1/FeaturestoreServiceClientTest.php
View file
Expand Up @@ -483,12 +483,14 @@ public function createFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$anyResponse = new Any();
$anyResponse->setValue($expectedResponse->serializeToString());
$completeOperation = new Operation();
Expand Down Expand Up @@ -1404,12 +1406,14 @@ public function getFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name2);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$transport->addResponse($expectedResponse);
// Mock request
$formattedName = $gapicClient->featureName('[PROJECT]', '[LOCATION]', '[FEATURESTORE]', '[ENTITY_TYPE]', '[FEATURE]');
Expand Down Expand Up @@ -2003,12 +2007,14 @@ public function updateFeatureTest()
$etag = 'etag3123477';
$disableMonitoring = false;
$versionColumnName = 'versionColumnName-1981743891';
$pointOfContact = 'pointOfContact1207498695';
$expectedResponse = new Feature();
$expectedResponse->setName($name);
$expectedResponse->setDescription($description);
$expectedResponse->setEtag($etag);
$expectedResponse->setDisableMonitoring($disableMonitoring);
$expectedResponse->setVersionColumnName($versionColumnName);
$expectedResponse->setPointOfContact($pointOfContact);
$transport->addResponse($expectedResponse);
// Mock request
$feature = new Feature();
Expand Down

0 comments on commit f27cfba

Please sign in to comment.