Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cloud-core minimum dependency #786

Closed
wants to merge 1 commit into from

Conversation

jackchuka
Copy link

To fix the issue: #782

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 12, 2017
@jackchuka
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Dec 12, 2017
@jdpedrie
Copy link
Contributor

Thanks for the contribution, @jackchuka. After discussing with @dwsupplee, we feel it's best to bump the required version for all components to the latest cloud-core (^1.14) in order to establish a new baseline from which we can be more diligent about future changes to the required version in the various components.

I'm quite interested in hearing your thoughts on this idea, as a user of the library who has encountered an issue which our proposal will effect. Would our proposal negatively impact you in any way?

@jackchuka
Copy link
Author

jackchuka commented Dec 13, 2017

Hi @jdpedrie, thanks for hearing me out on this.
I totally agree with you two and I'd say go for it. We won't have any negative impact due to this proposal. Besides, creating a new baseline will ensure that the each components are up to date and as a user of the library, I feel more confident to use/update the package as well.

@jdpedrie
Copy link
Contributor

@jackchuka please take a look at #790!

@jdpedrie jdpedrie closed this Dec 13, 2017
@jackchuka jackchuka deleted the patch-1 branch December 14, 2017 03:01
@jackchuka
Copy link
Author

Hi @jdpedrie, just wondering when will this #790 patch be released?

@jdpedrie
Copy link
Contributor

@jackchuka I'm planning on releasing it in v0.47.0, which should be out later today if all goes as planned.

gcf-owl-bot bot added a commit that referenced this pull request Mar 21, 2023
Source-Link: googleapis/googleapis@f64a3c8

Source-Link: googleapis/googleapis-gen@808541b
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiODA4NTQxYjdlNzY5N2UyOTg0YTBlYTBlYmExYWRiNTU2MGRhZGU5NyJ9
bshaffer pushed a commit that referenced this pull request Mar 22, 2023
Source-Link: googleapis/googleapis@f64a3c8
Source-Link: googleapis/googleapis-gen@808541b
Copy-Tag: eyJwIjoiQ29tcHV0ZS8uT3dsQm90LnlhbWwiLCJoIjoiODA4NTQxYjdlNzY5N2UyOTg0YTBlYTBlYmExYWRiNTU2MGRhZGU5NyJ9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants