Update required cloud-core version#790
Merged
jdpedrie merged 1 commit intogoogleapis:masterfrom Dec 14, 2017
jdpedrie:cloud-core-dep
Merged
Update required cloud-core version#790jdpedrie merged 1 commit intogoogleapis:masterfrom jdpedrie:cloud-core-dep
jdpedrie merged 1 commit intogoogleapis:masterfrom
jdpedrie:cloud-core-dep
Conversation
googlebot
added
the
cla: yes
Contributor
|
My initial thought is yes. cloud-core is GA, so we should never introduce breaking changes, and therefore there seems to be no downside in requiring the version to be updated. Is there any scenario where a user might need to depend on an old version of cloud-core? |
Contributor
|
We do have the Batch components in there which are experimental. |
Contributor
|
I like the safety of always requiring the latest code. Users utilizing experimental components should be aware of the fact they may need to upgrade, so it seems like a fair trade off. |
dwsupplee
approved these changes
Dec 14, 2017
Contributor
Author
|
Sounds good. I'll work on that soon and submit it in a separate pull request. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #782. Replaces #786.
Question for the group: Would it be useful to script automated requirement bumps into the release process? i.e. when a new release of cloud-core is created, should we automatically update the requirement in all packages depending on cloud-core?