Use dedicated PHPUnit assertions #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carusogabriel
requested review from
chingor13,
dwsupplee,
jdpedrie and
tmatsuo
as code owners
googlebot
added
the
cla: yes
dwsupplee
reviewed
Oct 2, 2018
There was a problem hiding this comment.
Thanks for this :)
Any of the tests following a structure of */tests/Unit/V*/* are actually auto-generated. We would need to update the template found in this repository or the next time we generate they'll just wipe out these changes. Would you be able to omit those here and we can follow them up on the generator?
|
@dwsupplee Sure. Gonna update the template and remove those from this patch :) |
|
Awesome! This is the file that needs to be touched: https://github.com/googleapis/gapic-generator/blob/master/src/main/resources/com/google/api/codegen/php/test.snip |
dwsupplee
approved these changes
Oct 2, 2018
dwsupplee
suggested changes
Oct 2, 2018
Vision/tests/Unit/ImageTest.php
Outdated
| @@ -157,6 +157,6 @@ public function testUrlSchemes() | |||
| $this->assertEquals($urls[0], $images[0]->requestObject()['image']['source']['imageUri']); | |||
| $this->assertEquals($urls[1], $images[1]->requestObject()['image']['source']['imageUri']); | |||
| $this->assertEquals($urls[2], $images[2]->requestObject()['image']['source']['imageUri']); | |||
| $this->assertFalse(isset($images[3]->requestObject()['image']['source']['imageUri'])); | |||
| $this->assertArrayNotHasKey('imageUri', $images[3]->requestObject()['image']['source']); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Datastore/tests/Unit/EntityTest.php
Outdated
| @@ -66,7 +66,7 @@ public function testCreateEntity() | |||
| $this->assertNull($entity->nonExistentMagicProperty); | |||
| $this->assertObjectNotHasAttribute('nonExistentMagicProperty', $entity); | |||
|
|
|||
| $this->assertTrue(isset($entity->magicProperty)); | |||
| $this->assertObjectHasAttribute('magicProperty', $entity); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dwsupplee
approved these changes
Oct 2, 2018
Merged
jdpedrie
added a commit
that referenced
this pull request
Oct 8, 2018
## Google Cloud PHP v0.82.0 ### google/cloud-bigquery v1.4.5 * Remove unnecessary ternary expression (#1327) * Use dedicated PHPUnit assertions (#1331) ### google/cloud-core v1.23.7 * Use combined assignment operators when possible (#1328) * Remove unused variables passed to closures (#1330) ### google/cloud-datastore v1.5.10 * Use combined assignment operators when possible (#1328) * Use dedicated PHPUnit assertions (#1331) ### google/cloud-debugger v0.14.2 * Remove unused variables passed to closures (#1330) * Use dedicated PHPUnit assertions (#1331) ### google/cloud-firestore v0.15.3 * Fix handling of empty sets in Firestore updates (#1316) * Remove auxiliary variables when they are return right away (#1329) ### google/cloud-spanner v1.11.0 * Use combined assignment operators when possible (#1328) * Remove unused variables passed to closures (#1330) * Add support for DML and Partitioned DML (#1309) ### google/cloud-storage v1.9.1 * Use dedicated PHPUnit assertions (#1331) ### google/cloud-vision v0.17.2 * Use dedicated PHPUnit assertions (#1331)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #862, #774 and #769