New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding kokoro config for windows #1339
Conversation
Kokoro windows test is passing for the first time :) |
Can you do a sanity check on the logs of the windows tests?
Maybe you can glance the number of skipped tests and see if the number is within your expectation. BTW, all the tests are passing, but I noticed the kokoro job on linux doesn't notify to this PR. Possibly we'll need to have a single parent. I'm asking the kokoro team if it's an intended behavior. |
Looks good to me. Skipped tests are inline with what we saw on appveyor. |
I separated the notification message for the child jobs. We can just ignore the notifications titled |
@jdpedrie Alright, I think it's ready for review and merge. Can you take a look? |
Thanks! |
TODOs