Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding kokoro config for windows #1339

Merged
merged 6 commits into from Oct 12, 2018
Merged

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Oct 9, 2018

TODOs

  • Add other PHP versions
  • Make them children of the main kokoro job or a new parent job for windows
  • Determine if we need to have a single parent?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 9, 2018
@tmatsuo tmatsuo added do not merge Indicates a pull request not ready for merge, due to either quality or timing. testing windows labels Oct 9, 2018
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Oct 11, 2018

Kokoro windows test is passing for the first time :)
https://source.cloud.google.com/results/invocations/7fb3f264-4f86-436b-b568-3b67f424d68f/targets

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Oct 11, 2018

@jdpedrie

Can you do a sanity check on the logs of the windows tests?

  1. visit the resultstore UI
  2. Click Invocation Log
  3. Copy the resultstore URL for the individual child jobs and visit it, then click Invocation Log

Maybe you can glance the number of skipped tests and see if the number is within your expectation.

BTW, all the tests are passing, but I noticed the kokoro job on linux doesn't notify to this PR. Possibly we'll need to have a single parent. I'm asking the kokoro team if it's an intended behavior.

@jdpedrie
Copy link
Contributor

Looks good to me. Skipped tests are inline with what we saw on appveyor.

@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2018
@tmatsuo tmatsuo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 12, 2018
@kokoro-team kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 12, 2018
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Oct 12, 2018

I separated the notification message for the child jobs. We can just ignore the notifications titled child job for now. Kokoro team is working on to disable notifications from child jobs.

@tmatsuo tmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2018
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Oct 12, 2018

@jdpedrie Alright, I think it's ready for review and merge. Can you take a look?

@tmatsuo tmatsuo changed the title Adding kokoro config for php72 test on windows Adding kokoro config for windows Oct 12, 2018
@tmatsuo tmatsuo merged commit 7f9d770 into googleapis:master Oct 12, 2018
@tmatsuo tmatsuo deleted the kokoro-win branch October 12, 2018 23:28
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Oct 12, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. testing windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants