[BC Break] Storage IAM #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpedrie
added
api: pubsub
googlebot
added
the
cla: yes
|
|
jdpedrie
removed
the
do not merge
dwsupplee
reviewed
Mar 27, 2017
src/Core/Iam/Iam.php
Outdated
| * @param array $options Configuration Options | ||
| * @return array An array of policy data | ||
| * @throws BadMethodCallException If the given policy is not an array or PolicyBuilder. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
src/Core/Iam/Iam.php
Outdated
| } | ||
|
|
||
| if (!is_array($policy)) { | ||
| throw new \BadMethodCallException('Given policy data must be an array or an instance of PolicyBuilder.'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dwsupplee all set! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #386.
Here is the implementation of IAM for GCS. It's a bit more involved than I expected. The storage IAM resources are just different enough to require modifications to the IAM system.
I also modified the Pub/Sub classes which implement IAM slightly, to delay creating the IAM objects until they're actually needed.
NOTE The return value of
Iam::testPermissions()has changed. Where it previously returned the API result, now it only returns the value of thepermissionskey on that result, or an empty array.todo