Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add back projectName methods for monitoring clients #5219

Merged
merged 1 commit into from
Apr 22, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion Monitoring/owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,11 @@
src=src,
dest=dest,
copy_excludes=[
src / "*/src/V3/AlertPolicyServiceClient.php"
src / "*/src/V3/AlertPolicyServiceClient.php",
src / "*/src/V3/GroupServiceClient.php",
src / "*/src/V3/NotificationChannelServiceClient.php",
src / "*/src/V3/ServiceMonitoringServiceClient.php",
src / "*/src/V3/UptimeCheckServiceGapicClient.php",
]
)

Expand Down
17 changes: 15 additions & 2 deletions Monitoring/src/V3/GroupServiceClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@
/** {@inheritdoc} */
class GroupServiceClient extends GroupServiceGapicClient
{
// This class is intentionally empty, and is intended to hold manual additions to
// the generated {@see GroupServiceGapicClient} class.
/**
* Formats a string containing the fully-qualified path to represent
* a project resource.
*
* @param string $project
*
* @return string The formatted project resource.
* @deprecated
*/
public static function projectName($project)
{
return (new PathTemplate('projects/{project}'))->render([
'project' => $project,
]);
}
}
17 changes: 15 additions & 2 deletions Monitoring/src/V3/NotificationChannelServiceClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@
/** {@inheritdoc} */
class NotificationChannelServiceClient extends NotificationChannelServiceGapicClient
{
// This class is intentionally empty, and is intended to hold manual additions to
// the generated {@see NotificationChannelServiceGapicClient} class.
/**
* Formats a string containing the fully-qualified path to represent
* a project resource.
*
* @param string $project
*
* @return string The formatted project resource.
* @deprecated
*/
public static function projectName($project)
{
return (new PathTemplate('projects/{project}'))->render([
'project' => $project,
]);
}
}
17 changes: 15 additions & 2 deletions Monitoring/src/V3/ServiceMonitoringServiceClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@
/** {@inheritdoc} */
class ServiceMonitoringServiceClient extends ServiceMonitoringServiceGapicClient
{
// This class is intentionally empty, and is intended to hold manual additions to
// the generated {@see ServiceMonitoringServiceGapicClient} class.
/**
* Formats a string containing the fully-qualified path to represent
* a project resource.
*
* @param string $project
*
* @return string The formatted project resource.
* @deprecated
*/
public static function projectName($project)
{
return (new PathTemplate('projects/{project}'))->render([
'project' => $project,
]);
}
}
17 changes: 15 additions & 2 deletions Monitoring/src/V3/UptimeCheckServiceClient.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,19 @@
/** {@inheritdoc} */
class UptimeCheckServiceClient extends UptimeCheckServiceGapicClient
{
// This class is intentionally empty, and is intended to hold manual additions to
// the generated {@see UptimeCheckServiceGapicClient} class.
/**
* Formats a string containing the fully-qualified path to represent
* a project resource.
*
* @param string $project
*
* @return string The formatted project resource.
* @deprecated
*/
public static function projectName($project)
{
return (new PathTemplate('projects/{project}'))->render([
'project' => $project,
]);
}
}