Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(tests): require BREAKING_CHANGE_REASON when using "breaking change allowed" label #5958

Merged
merged 17 commits into from
Mar 24, 2023
Merged

chore(tests): require BREAKING_CHANGE_REASON when using "breaking change allowed" label #5958

merged 17 commits into from
Mar 24, 2023

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Mar 13, 2023 •
edited
Loading

No description provided.

@bshaffer bshaffer changed the title test commenting on PR chore(tests): require BREAKING_CHANGE_JUSTIFICATION when "breaking change allowed" Mar 13, 2023
@googleapis googleapis deleted a comment from github-actions bot Mar 13, 2023
@github-actions
Copy link

github-actions bot commented Mar 13, 2023 •
edited
Loading

To skip the breaking change detector, the PR must contain a BREAKING_CHANGE_REASON=[reason]
in the PR description.

@bshaffer
Copy link
Contributor Author

@vishwarajanand what do you think??

@bshaffer bshaffer marked this pull request as ready for review March 14, 2023 15:13
@bshaffer bshaffer requested review from a team as code owners March 14, 2023 15:13
@bshaffer bshaffer changed the title chore(tests): require BREAKING_CHANGE_JUSTIFICATION when "breaking change allowed" chore(tests): require breaking change justification when using "breaking change allowed" label Mar 14, 2023
@bshaffer bshaffer added the next release PRs to be included in the next release label Mar 16, 2023
@bshaffer
Copy link
Contributor Author

bshaffer commented Mar 22, 2023 •
edited
Loading

@vishwarajanand this now works when adding/removing labels. The BC-checker workflow is re-triggered

see af42a8e

vishwarajanand
vishwarajanand approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@vishwarajanand vishwarajanand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bshaffer
Copy link
Contributor Author

bshaffer commented Mar 24, 2023 •
edited
Loading

See if it works to put this in a comment

BREAKING_CHANGE_REASON=this is a test breaking change reason

update: (this did not work)

@bshaffer bshaffer enabled auto-merge (squash) March 24, 2023 16:50
@bshaffer bshaffer disabled auto-merge March 24, 2023 16:50
@bshaffer bshaffer changed the title chore(tests): require breaking change justification when using "breaking change allowed" label chore(tests): require BREAKING_CHANGE_REASON when using "breaking change allowed" label Mar 24, 2023
@bshaffer bshaffer enabled auto-merge (squash) March 24, 2023 16:51
@bshaffer bshaffer merged commit 3cf139d into main Mar 24, 2023
@bshaffer bshaffer deleted the add-bccheck-comment branch March 24, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishwarajanand vishwarajanand vishwarajanand approved these changes

Assignees
No one assigned
Labels
next release PRs to be included in the next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bshaffer @vishwarajanand