Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: promote AdvisoryNotifications, ApiKeys, BareMetalSolution, BigQueryAnalyticsHub, BigQueryMigration #7429

Merged
merged 3 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .repo-metadata-full.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"AdvisoryNotifications": {
"language": "php",
"distribution_name": "google/cloud-advisorynotifications",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-advisorynotifications/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "advisorynotifications"
Expand Down Expand Up @@ -66,7 +66,7 @@
"ApiKeys": {
"language": "php",
"distribution_name": "google/cloud-api-keys",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-api-keys/latest",
"library_type": "GAPIC_AUTO",
"product_documentation": "https://cloud.google.com/api-keys/docs",
Expand Down Expand Up @@ -172,7 +172,7 @@
"BareMetalSolution": {
"language": "php",
"distribution_name": "google/cloud-bare-metal-solution",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-bare-metal-solution/latest",
"library_type": "GAPIC_AUTO",
"api_shortname": "baremetalsolution"
Expand Down Expand Up @@ -240,7 +240,7 @@
"BigQueryAnalyticsHub": {
"language": "php",
"distribution_name": "google/cloud-bigquery-analyticshub",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-bigquery-analyticshub/latest",
"library_type": "GAPIC_AUTO",
"product_documentation": "https://cloud.google.com/analytics-hub",
Expand Down Expand Up @@ -284,7 +284,7 @@
"BigQueryMigration": {
"language": "php",
"distribution_name": "google/cloud-bigquery-migration",
"release_level": "preview",
"release_level": "stable",
"client_documentation": "https://cloud.google.com/php/docs/reference/cloud-bigquery-migration/latest",
"library_type": "GAPIC_AUTO",
"product_documentation": "https://cloud.google.com/bigquery/docs/migration-intro/docs",
Expand Down
4 changes: 2 additions & 2 deletions AdvisoryNotifications/.OwlBot.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
deep-copy-regex:
- source: /google/cloud/advisorynotifications/v1/.*-php/(.*)
dest: /owl-bot-staging/AdvisoryNotifications/v1/$1
- source: /google/cloud/advisorynotifications/(v1)/.*-php/(.*)
dest: /owl-bot-staging/AdvisoryNotifications/$1/$2
api-name: AdvisoryNotifications
3 changes: 2 additions & 1 deletion AdvisoryNotifications/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ See the [samples directory](https://github.com/googleapis/google-cloud-php-advis

### Version

This component is considered alpha. As such, it is still a work-in-progress and is more likely to get backwards-incompatible updates.
This component is considered GA (generally available). As such, it will not introduce backwards-incompatible changes in
any minor or patch releases. We will address issues and requests with the highest priority.

### Next Steps

Expand Down
13 changes: 3 additions & 10 deletions AdvisoryNotifications/owlbot.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,7 @@
# Added so that we can pass copy_excludes in the owlbot_main() call
_tracked_paths.add(src)

php.owlbot_main(
src=src,
dest=dest,
copy_excludes=[
src / "**/[A-Z]*_*.php",
src / "**/*GrpcClient.php"
]
)
php.owlbot_main(src=src, dest=dest)

# remove class_alias code
s.replace(
Expand All @@ -56,8 +49,8 @@
'--package=@prettier/plugin-php@^0.16',
'--',
'prettier',
'**/Gapic/*',
'**/Client/*',
'--write',
'--parser=php',
'--single-quote',
'--print-width=80'])
'--print-width=120'])

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?php
/*
* Copyright 2023 Google LLC
* Copyright 2024 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -82,9 +82,7 @@ final class AdvisoryNotificationsServiceClient
private const CODEGEN_NAME = 'gapic';

/** The default scopes required by the service. */
public static $serviceScopes = [
'https://www.googleapis.com/auth/cloud-platform',
];
public static $serviceScopes = ['https://www.googleapis.com/auth/cloud-platform'];

private static function getClientDefaults()
{
Expand All @@ -99,7 +97,8 @@ private static function getClientDefaults()
],
'transportConfig' => [
'rest' => [
'restClientConfigPath' => __DIR__ . '/../resources/advisory_notifications_service_rest_client_config.php',
'restClientConfigPath' =>
__DIR__ . '/../resources/advisory_notifications_service_rest_client_config.php',
],
],
];
Expand Down Expand Up @@ -168,8 +167,11 @@ public static function organizationLocationName(string $organization, string $lo
*
* @return string The formatted organization_location_notification resource.
*/
public static function organizationLocationNotificationName(string $organization, string $location, string $notification): string
{
public static function organizationLocationNotificationName(
string $organization,
string $location,
string $notification
): string {
return self::getPathTemplate('organizationLocationNotification')->render([
'organization' => $organization,
'location' => $location,
Expand Down Expand Up @@ -221,8 +223,11 @@ public static function projectLocationName(string $project, string $location): s
*
* @return string The formatted project_location_notification resource.
*/
public static function projectLocationNotificationName(string $project, string $location, string $notification): string
{
public static function projectLocationNotificationName(
string $project,
string $location,
string $notification
): string {
return self::getPathTemplate('projectLocationNotification')->render([
'project' => $project,
'location' => $location,
Expand Down
Loading
Loading