-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Logging #97
Generate Logging #97
Conversation
@@ -8,6 +8,9 @@ | |||
<filter> | |||
<whitelist> | |||
<directory suffix=".php">src</directory> | |||
<exclude> | |||
<directory suffix=".php">src/Logging/V2</directory> |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Is there anything else that needs to be addressed on this PR before it can be merged? |
This is looking good. The only issue on this PR I would like to discuss still is in regards to @michaelbausor's point regarding the resources directory. We haven't decided whether we will publish each API as it's own package yet. If we do, however, placing the resource files in src/Logging would help make the transition easier. What do you think? |
Does it make sense to place them inside the major version folder? e.g. |
That sounds perfect! |
|
||
// TODO load the client config in a more package-friendly way | ||
// https://github.com/googleapis/toolkit/issues/332 | ||
$clientConfigJsonString = file_get_contents('./resources/config_service_v2_client_config.json'); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Why do the classes end in |
We are appending the |
Sorry I have let this sit for a week. I have updated the logging surface with our latest generator. I also updated the google/auth dependency to 0.10, which is required by google/gax to use the caching functionality that has been added. Please let me know if there are more issues that need to be addressed. |
Thank you for the updates. Should #62 lead this? It looks like it includes the necessary dependencies. On that note, though, what do you think about moving those dependencies from |
That seems sensible to me. @garrettjonesgoogle what are your thoughts? This PR should probably not block on #62, because the PubSub surface does not yet support IAM methods. Support for those should be coming soon, but isn't available yet. I will add the dependencies to this PR. Note also that since Stanley has flagged release versions for grpc (https://packagist.org/packages/grpc/grpc#v1.0.0) and protobuf (https://packagist.org/packages/stanley-cheung/protobuf-php#v0.6) we should not require |
@michaelbausor @dwsupplee Moving the dependencies from |
This PR separates the generation of Logging from Pubsub in #62
One point for discussion/review is that the json files with retry settings are in a top level directory called resources. What would be the best way to provide these files?