Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using mutate_rows() instead of row.commit() #54

Merged
merged 5 commits into from Dec 3, 2018
Merged

Using mutate_rows() instead of row.commit() #54

merged 5 commits into from Dec 3, 2018

Conversation

sumit-ql
Copy link
Contributor

@sumit-ql sumit-ql commented Dec 2, 2018

This is a fix for #4

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2018
tseaver
tseaver suggested changes Dec 3, 2018
View reviewed changes
unit_tests/test_batch.py Outdated Show resolved Hide resolved
unit_tests/test_batch.py Outdated Show resolved Hide resolved
unit_tests/test_batch.py Outdated Show resolved Hide resolved
unit_tests/test_batch.py Outdated Show resolved Hide resolved
@sumit-ql
Copy link
Contributor Author

sumit-ql commented Dec 3, 2018

@tseaver Incorporated review comments, please review.

@tseaver tseaver merged commit 50c1562 into googleapis:master Dec 3, 2018
@sumit-ql sumit-ql deleted the mutation-batcher branch December 4, 2018 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sumit-ql @tseaver @googlebot