Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kokoro #61

Merged
merged 15 commits into from Feb 5, 2019
Merged

Add kokoro #61

merged 15 commits into from Feb 5, 2019

Conversation

busunkim96
Copy link
Contributor

  • Remove Appveyor
  • Remove Coveralls
  • Use nox

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2019
sduskis
sduskis suggested changes Jan 25, 2019
View reviewed changes
Copy link

@sduskis sduskis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot going on in this PR. Is it possible to split out the formatting changes from the kokoro changes?

.kokoro/continuous.cfg Show resolved Hide resolved
.kokoro/presubmit.cfg Show resolved Hide resolved
.kokoro/release.cfg Show resolved Hide resolved
@busunkim96
Copy link
Contributor Author

@sduskis That sounds good, I'll separate out the PRs.

@busunkim96 busunkim96 mentioned this pull request Jan 29, 2019
Merged
crwilcox
crwilcox approved these changes Feb 2, 2019
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few changes post my changes. Turns out my encoding tests aren't going to fail under python2 since it doesn't care if the strings are bytes or not. Also changed the targets in noxfile to match our other python projects.

@busunkim96 busunkim96 changed the title WIP: Add kokoro Add kokoro Feb 5, 2019
@busunkim96 busunkim96 merged commit 0d5f078 into master Feb 5, 2019
@parthea parthea deleted the add-kokoro branch October 1, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sduskis sduskis sduskis requested changes

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@busunkim96 @sduskis @crwilcox @googlebot