Address puts failing with non-encoded column names. Add test that asserts this. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crwilcox
changed the title
sduskis
reviewed
Jan 28, 2019
tseaver
suggested changes
Jan 29, 2019
crwilcox
force-pushed
the
handle-not-encoded-column-names
branch
from
c5b9bc1
to
b0ba23f
Compare
sduskis
approved these changes
Feb 1, 2019
tseaver
approved these changes
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects behavior in 0.32.1 to match 0.31.0. A case was introduced that threw errors to user when a non-encoded column name was used.
Also, adding noxfile. Running the system tests using the method used in tox wasn't actually failing here. @busunkim96 in a separate pr is working on kokoro. I can drop noxfile before committing this if preferred, but I saw no harm in putting it in now.