Skip to content

Commit

Permalink
feat(bigquery): add timeout parameter to client's and job's public me…
Browse files Browse the repository at this point in the history
…thods (#10002)

* Reverse argument order in job.result()

This is for internal consistency with other methods such as reload().

* Add TODO reminder to _AsyncJob.cancel() method

* Add timeout argument to public methods

AN exception is the Client.load_table_from_file() method, and the
methods that depend on it, because adding a timeout requires changes
in the google-resumable-media dependency.

* Explicitly test timeout parameter

* Split timeout in multi-request methods

If a method makes multiple requests and is given a timeout, that
timeout should represent the total allowed time for all requests
combined.

* Fix minor styling issue

* Add timeout with retry test for Client._call_api()
  • Loading branch information
plamut committed Dec 26, 2019
1 parent ae22885 commit 26dd729
Show file tree
Hide file tree
Showing 5 changed files with 910 additions and 204 deletions.
Loading

0 comments on commit 26dd729

Please sign in to comment.