feat: [google-cloud-recommender] Support cost_in_local_currency field…

… in the cost projection (#12112) BEGIN_COMMIT_OVERRIDE feat: Support cost_in_local_currency field in the cost projection docs: Fix typo for the comment of reliability_projection docs: Add comment for targetResources END_COMMIT_OVERRIDE - [ ] Regenerate this pull request now. docs: Fix typo for the comment of reliability_projection docs: Add comment for targetResources PiperOrigin-RevId: 589982370 Source-Link: googleapis/googleapis@b7abf5c Source-Link: googleapis/googleapis-gen@1617d1e Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLXJlY29tbWVuZGVyLy5Pd2xCb3QueWFtbCIsImgiOiIxNjE3ZDFlZGUyYTA1YzEzMjg5Y2ZlYTQ4ODNiY2RmOTExNmY1NjRlIn0= --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
googleapis · Dec 12, 2023 · 8832a03 · 8832a03
1 parent e6b5ea0
commit 8832a03
Show file tree

Hide file tree

Showing 9 changed files with 39 additions and 7 deletions.
diff --git a/packages/google-cloud-recommender/google/cloud/recommender/gapic_version.py b/packages/google-cloud-recommender/google/cloud/recommender/gapic_version.py
@@ -13,4 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__version__ = "2.13.0"  # {x-release-please-version}
+__version__ = "0.0.0"  # {x-release-please-version}
diff --git a/packages/google-cloud-recommender/google/cloud/recommender_v1/gapic_version.py b/packages/google-cloud-recommender/google/cloud/recommender_v1/gapic_version.py
@@ -13,4 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__version__ = "2.13.0"  # {x-release-please-version}
+__version__ = "0.0.0"  # {x-release-please-version}
diff --git a/...google-cloud-recommender/google/cloud/recommender_v1/services/recommender/async_client.py b/...google-cloud-recommender/google/cloud/recommender_v1/services/recommender/async_client.py
@@ -708,6 +708,8 @@ async def sample_list_recommendations():
 
                 -  ``priority``
 
+                -  ``targetResources``
+
                 Examples:
 
                 -  ``stateInfo.state = ACTIVE OR stateInfo.state = DISMISSED``
@@ -716,8 +718,12 @@ async def sample_list_recommendations():
 
                 -  ``priority = P1 OR priority = P2``
 
+                -  ``targetResources : //compute.googleapis.com/projects/1234/zones/us-central1-a/instances/instance-1``
+
                 -  ``stateInfo.state = ACTIVE AND (priority = P1 OR priority = P2)``
 
+                The max allowed filter length is 500 characters.
+
                 (These expressions are based on the filter language
                 described at https://google.aip.dev/160)
 

diff --git a/packages/google-cloud-recommender/google/cloud/recommender_v1/services/recommender/client.py b/packages/google-cloud-recommender/google/cloud/recommender_v1/services/recommender/client.py
@@ -1018,6 +1018,8 @@ def sample_list_recommendations():
 
                 -  ``priority``
 
+                -  ``targetResources``
+
                 Examples:
 
                 -  ``stateInfo.state = ACTIVE OR stateInfo.state = DISMISSED``
@@ -1026,8 +1028,12 @@ def sample_list_recommendations():
 
                 -  ``priority = P1 OR priority = P2``
 
+                -  ``targetResources : //compute.googleapis.com/projects/1234/zones/us-central1-a/instances/instance-1``
+
                 -  ``stateInfo.state = ACTIVE AND (priority = P1 OR priority = P2)``
 
+                The max allowed filter length is 500 characters.
+
                 (These expressions are based on the filter language
                 described at https://google.aip.dev/160)
 

diff --git a/packages/google-cloud-recommender/google/cloud/recommender_v1/types/recommendation.py b/packages/google-cloud-recommender/google/cloud/recommender_v1/types/recommendation.py
@@ -439,6 +439,9 @@ class CostProjection(proto.Message):
             prices.
         duration (google.protobuf.duration_pb2.Duration):
             Duration for which this cost applies.
+        cost_in_local_currency (google.type.money_pb2.Money):
+            The approximate cost savings in the billing
+            account's local currency.
     """
 
     cost: money_pb2.Money = proto.Field(
@@ -451,6 +454,11 @@ class CostProjection(proto.Message):
         number=2,
         message=duration_pb2.Duration,
     )
+    cost_in_local_currency: money_pb2.Money = proto.Field(
+        proto.MESSAGE,
+        number=3,
+        message=money_pb2.Money,
+    )
 
 
 class SecurityProjection(proto.Message):
@@ -564,7 +572,7 @@ class Impact(proto.Message):
 
             This field is a member of `oneof`_ ``projection``.
         reliability_projection (google.cloud.recommender_v1.types.ReliabilityProjection):
-            Use with CategoryType.RELAIBILITY
+            Use with CategoryType.RELIABILITY
 
             This field is a member of `oneof`_ ``projection``.
     """

diff --git a/packages/google-cloud-recommender/google/cloud/recommender_v1/types/recommender_service.py b/packages/google-cloud-recommender/google/cloud/recommender_v1/types/recommender_service.py
@@ -94,6 +94,8 @@ class ListInsightsRequest(proto.Message):
 
             -  ``severity``
 
+            -  ``targetResources``
+
             Examples:
 
             -  ``stateInfo.state = ACTIVE OR stateInfo.state = DISMISSED``
@@ -102,8 +104,12 @@ class ListInsightsRequest(proto.Message):
 
             -  ``severity = CRITICAL OR severity = HIGH``
 
+            -  ``targetResources : //compute.googleapis.com/projects/1234/zones/us-central1-a/instances/instance-1``
+
             -  ``stateInfo.state = ACTIVE AND (severity = CRITICAL OR severity = HIGH)``
 
+            The max allowed filter length is 500 characters.
+
             (These expressions are based on the filter language
             described at https://google.aip.dev/160)
     """
@@ -239,6 +245,8 @@ class ListRecommendationsRequest(proto.Message):
 
             -  ``priority``
 
+            -  ``targetResources``
+
             Examples:
 
             -  ``stateInfo.state = ACTIVE OR stateInfo.state = DISMISSED``
@@ -247,8 +255,12 @@ class ListRecommendationsRequest(proto.Message):
 
             -  ``priority = P1 OR priority = P2``
 
+            -  ``targetResources : //compute.googleapis.com/projects/1234/zones/us-central1-a/instances/instance-1``
+
             -  ``stateInfo.state = ACTIVE AND (priority = P1 OR priority = P2)``
 
+            The max allowed filter length is 500 characters.
+
             (These expressions are based on the filter language
             described at https://google.aip.dev/160)
     """
@@ -319,7 +331,7 @@ class MarkRecommendationDismissedRequest(proto.Message):
 
     Attributes:
         name (str):
-            Name of the recommendation.
+            Required. Name of the recommendation.
         etag (str):
             Fingerprint of the Recommendation. Provides
             optimistic locking.

diff --git a/packages/google-cloud-recommender/google/cloud/recommender_v1beta1/gapic_version.py b/packages/google-cloud-recommender/google/cloud/recommender_v1beta1/gapic_version.py
@@ -13,4 +13,4 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__version__ = "2.13.0"  # {x-release-please-version}
+__version__ = "0.0.0"  # {x-release-please-version}
diff --git a/...d-recommender/samples/generated_samples/snippet_metadata_google.cloud.recommender.v1.json b/...d-recommender/samples/generated_samples/snippet_metadata_google.cloud.recommender.v1.json
@@ -8,7 +8,7 @@
     ],
     "language": "PYTHON",
     "name": "google-cloud-recommender",
-    "version": "2.13.0"
+    "version": "0.1.0"
   },
   "snippets": [
     {

diff --git a/...ommender/samples/generated_samples/snippet_metadata_google.cloud.recommender.v1beta1.json b/...ommender/samples/generated_samples/snippet_metadata_google.cloud.recommender.v1beta1.json
@@ -8,7 +8,7 @@
     ],
     "language": "PYTHON",
     "name": "google-cloud-recommender",
-    "version": "2.13.0"
+    "version": "0.1.0"
   },
   "snippets": [
     {