-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add v1alpha public library for discoveryengine #11796
feat: add v1alpha public library for discoveryengine #11796
Conversation
PiperOrigin-RevId: 572280880 Source-Link: googleapis/googleapis@f5cacaf Source-Link: googleapis/googleapis-gen@036171b Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRpc2NvdmVyeWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiMDM2MTcxYjY4ZGU1ODI5ZjVjZmE5Mjk0OTQ4NGNmY2I3ZjAwYWYyOCJ9
@@ -3,9 +3,17 @@ | |||
.. include:: multiprocessing.rst | |||
|
|||
This package includes clients for multiple versions of Discovery Engine API. | |||
By default, you will get version ``discoveryengine_v1``. | |||
By default, you will get version ``discoveryengine_v1beta``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is incorrect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default version is listed as v1beta here but it should be v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filed https://github.com/googleapis/google-cloud-python/issues/11799. I'm going to unblock this PR as we will be tracking the improvement in https://github.com/googleapis/google-cloud-python/issues/11799
🤖 I have created a release *beep* *boop* --- <details><summary>google-cloud-discoveryengine: 0.11.2</summary> ## [0.11.2](google-cloud-discoveryengine-v0.11.1...google-cloud-discoveryengine-v0.11.2) (2023-10-10) ### Features * add v1alpha public library for discoveryengine ([#11796](#11796)) ([e9ccb06](e9ccb06)) </details> <details><summary>google-cloud-documentai: 2.20.1</summary> ## [2.20.1](google-cloud-documentai-v2.20.0...google-cloud-documentai-v2.20.1) (2023-10-10) ### Documentation * minor comment update ([#11797](#11797)) ([1360d6b](1360d6b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
PiperOrigin-RevId: 572280880
Source-Link: googleapis/googleapis@f5cacaf
Source-Link: https://github.com/googleapis/googleapis-gen/commit/036171b68de5829f5cfa92949484cfcb7f00af28
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRpc2NvdmVyeWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiMDM2MTcxYjY4ZGU1ODI5ZjVjZmE5Mjk0OTQ4NGNmY2I3ZjAwYWYyOCJ9