Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add v1alpha public library for discoveryengine #11796

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Oct 10, 2023

  • Regenerate this pull request now.

PiperOrigin-RevId: 572280880

Source-Link: googleapis/googleapis@f5cacaf

Source-Link: https://github.com/googleapis/googleapis-gen/commit/036171b68de5829f5cfa92949484cfcb7f00af28
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRpc2NvdmVyeWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiMDM2MTcxYjY4ZGU1ODI5ZjVjZmE5Mjk0OTQ4NGNmY2I3ZjAwYWYyOCJ9

PiperOrigin-RevId: 572280880

Source-Link: googleapis/googleapis@f5cacaf

Source-Link: googleapis/googleapis-gen@036171b
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlLWNsb3VkLWRpc2NvdmVyeWVuZ2luZS8uT3dsQm90LnlhbWwiLCJoIjoiMDM2MTcxYjY4ZGU1ODI5ZjVjZmE5Mjk0OTQ4NGNmY2I3ZjAwYWYyOCJ9
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Oct 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2023
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review October 10, 2023 18:54
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner October 10, 2023 18:54
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 10, 2023
@snippet-bot
Copy link

snippet-bot bot commented Oct 10, 2023

Here is the summary of changes.

You are about to add 52 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@@ -3,9 +3,17 @@
.. include:: multiprocessing.rst

This package includes clients for multiple versions of Discovery Engine API.
By default, you will get version ``discoveryengine_v1``.
By default, you will get version ``discoveryengine_v1beta``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default version is listed as v1beta here but it should be v1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I filed https://github.com/googleapis/google-cloud-python/issues/11799. I'm going to unblock this PR as we will be tracking the improvement in https://github.com/googleapis/google-cloud-python/issues/11799

@parthea parthea enabled auto-merge (squash) October 10, 2023 20:37
@parthea parthea merged commit e9ccb06 into main Oct 10, 2023
14 of 15 checks passed
@parthea parthea deleted the owl-bot-copy-packages-google-cloud-discoveryengine branch October 10, 2023 20:45
@release-please release-please bot mentioned this pull request Oct 10, 2023
parthea pushed a commit that referenced this pull request Oct 10, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>google-cloud-discoveryengine: 0.11.2</summary>

##
[0.11.2](google-cloud-discoveryengine-v0.11.1...google-cloud-discoveryengine-v0.11.2)
(2023-10-10)


### Features

* add v1alpha public library for discoveryengine
([#11796](#11796))
([e9ccb06](e9ccb06))
</details>

<details><summary>google-cloud-documentai: 2.20.1</summary>

##
[2.20.1](google-cloud-documentai-v2.20.0...google-cloud-documentai-v2.20.1)
(2023-10-10)


### Documentation

* minor comment update
([#11797](#11797))
([1360d6b](1360d6b))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant