New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test assertion in test_wrap_method_with_overriding_retry_deadline #4131
Conversation
@@ -156,7 +156,8 @@ def test_wrap_method_with_overriding_retry_deadline(unusued_sleep): | |||
|
|||
assert result == 42 | |||
timeout_args = [call[1]['timeout'] for call in method.call_args_list] | |||
assert timeout_args == [5, 10, 20, 29] | |||
# Timeout should never exceed 30s. | |||
assert max(timeout_args) <= 30 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
assert utcnow.call_count == ( | ||
1 + # First to set the deadline. | ||
5 + # One for each min(timeout, maximum, (DEADLINE - NOW).seconds) | ||
5 |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Fixes #4128