Remove datastore.Dataset class #477

dhermes · 2015-01-02T19:26:51Z

The replacement will be handled by a string when dataset ID is explicitly needed (which will only be for power users). Some functionality will be moved to key.Key and the rest to the connection module as free functions. In order to make use easier, they will also have versions in __init__ which can use a default / implicit connection.

Steps to complete:

Make set_default_connection similar to set_default_dataset (Address first part of 477: Implements datastore.set_default_connection. #478)
Remove ~~query(),~~ entity(), and transaction() methods from Dataset, replace their use elsewhere. (Address second part of 477: Remove query(), entity(), and transaction() methods from Dataset. #479)
Move Dataset.get_entity to Key (will impact elsewhere, e.g. Entity.reload) (Address third part of 477: Move Dataset.get_entity to Key. #480)
Move ~~save() and delete() methods~~ delete() method from Entity to Key (Address fourth part of 477: Moving Entity.delete to Key (for datastore). #481)
Move allocate_ids() method from Dataset to ~~connection~~ __init__ module as free function (Address fifth part of 477: Moves Dataset.allocate_ids to connection module. #482)
Move get_entities() method from Dataset to ~~connection~~ __init__ module as free function (Address sixth part of 477: Moves Dataset.get_entities to __init__ module. #483)
Fix ~~Remove dataset from Entity constructor and allow a key #484, Remove Query dependency on Dataset and make dataset_id required in Query #485, Remove Transaction dependency on Dataset #486~~ - Lots to do to re-make Entity, Query, and Transaction to not depend on Dataset
Remove all remnants of Dataset (e.g. set_default_dataset, Entity._must_dataset, and _implicit_environ._DatastoreBase)
Update stale documentation

NOTE: Don't close until cyclic-import in #480 is resolved.

See https://docs.google.com/document/d/1xKw8Tz6lfN5uOcv0my4uUgFSeDoRzwCLho2UGlBpqDU/edit for more.

The text was updated successfully, but these errors were encountered:

This allows methods which rely on a connection to be used with no arguments. Fixes first part of googleapis#477.

Addresses second part of googleapis#477.

Addresses third part of googleapis#477.

Addresses fourth part of googleapis#477.

Addresses fifth part of googleapis#477.

Addresses sixth part of googleapis#477.

This allows methods which rely on a connection to be used with no arguments. Fixes first part of googleapis#477.

Addresses second part of googleapis#477.

Addresses third part of googleapis#477.

Addresses fourth part of googleapis#477.

Addresses fifth part of googleapis#477.

Addresses sixth part of googleapis#477.

Addresses part 8 of googleapis#477.

dhermes · 2015-01-08T03:05:49Z

Re-opening until cyclic-imports are resolved.

Removed Entity.reload() because it relied on the existence of Key.get(). Replacing it would have required import gcloud.datastore.get in entity.py, which would have again been a cyclic import. With an eye on removing the Entity class (see googleapis#490), removing Entity.reload() is not such a big deal. Fixes googleapis#477.

dhermes · 2015-01-08T19:16:55Z

Closed for #517

* WIP: reader to reconnect on ReadRows streams * Add method to copy a StreamPosition. * Add unit tests for hand-written reader module. * Add docs for new hand-written module. * Add fastavro to root intersphinx * Add ServiceUnavailable to list of resumable exceptions. Pull in .coveragerc file from upstream google-cloud-python.

* Generate google-cloud-bigquery-storage library using synthtool. (#472) * Add simple system test for BigQuery Storage API (#473) * Add simple system test for BigQuery Storage API For the system tests to run correctly, an unreleased version of api_core is required. Updates the setup.py file to indicate the minimum version. * Remove mock dependency and unnecessary imports. * Use -e for local deps. * Add manual client for BigQuery Storage (#474) * Add manual client for BigQuery Storage. The manual client adds a default project, which is used by the wrapped create_read_session to make the project parameter optional. A future purpose of the manual client is to override the read_rows method to return an iterator that can reconnect with the correct offset, much like Spanner's StreamedResultSet class. This work is not yet complete. I'd like feedback on the approach for the manual client first. * Use same client name as wrapped gapic class. * Use subclass for BigQueryStorageClient Also, change create_read_session project argument back to 'parent' to better match the super class. * Add unit tests. * Remove default project from manual client. * Use project_id fixture in system tests. * Regenerate google-cloud-bigquery-storage (#475) * Regenerate google-cloud-bigquery-storage * Re-synthed * Handwritten reader to reconnect on ReadRows streams (#477) * WIP: reader to reconnect on ReadRows streams * Add method to copy a StreamPosition. * Add unit tests for hand-written reader module. * Add docs for new hand-written module. * Add fastavro to root intersphinx * Add ServiceUnavailable to list of resumable exceptions. Pull in .coveragerc file from upstream google-cloud-python.

* Generate google-cloud-bigquery-storage library using synthtool. (googleapis#472) * Add simple system test for BigQuery Storage API (googleapis#473) * Add simple system test for BigQuery Storage API For the system tests to run correctly, an unreleased version of api_core is required. Updates the setup.py file to indicate the minimum version. * Remove mock dependency and unnecessary imports. * Use -e for local deps. * Add manual client for BigQuery Storage (googleapis#474) * Add manual client for BigQuery Storage. The manual client adds a default project, which is used by the wrapped create_read_session to make the project parameter optional. A future purpose of the manual client is to override the read_rows method to return an iterator that can reconnect with the correct offset, much like Spanner's StreamedResultSet class. This work is not yet complete. I'd like feedback on the approach for the manual client first. * Use same client name as wrapped gapic class. * Use subclass for BigQueryStorageClient Also, change create_read_session project argument back to 'parent' to better match the super class. * Add unit tests. * Remove default project from manual client. * Use project_id fixture in system tests. * Regenerate google-cloud-bigquery-storage (googleapis#475) * Regenerate google-cloud-bigquery-storage * Re-synthed * Handwritten reader to reconnect on ReadRows streams (googleapis#477) * WIP: reader to reconnect on ReadRows streams * Add method to copy a StreamPosition. * Add unit tests for hand-written reader module. * Add docs for new hand-written module. * Add fastavro to root intersphinx * Add ServiceUnavailable to list of resumable exceptions. Pull in .coveragerc file from upstream google-cloud-python.

…mplates/python_library/.kokoro (#477) Source-Link: googleapis/synthtool@30bd01b Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@7197a00 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c43f1d918bcf817d337aa29ff833439494a158a0831508fda4ec75dc4c0d0320 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: googleapis/synthtool@571ee2c Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:660abdf857d3ab9aabcd967c163c70e657fcc5653595c709263af5f3fa23ef67

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Source-Link: googleapis/synthtool@5f2a608 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

dhermes added the api: datastore Issues related to the Datastore API. label Jan 2, 2015

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 2, 2015

Implements datastore.set_default_connection.

bdb69ac

This allows methods which rely on a connection to be used with no arguments. Fixes first part of googleapis#477.

dhermes mentioned this issue Jan 2, 2015

Address first part of 477: Implements datastore.set_default_connection. #478

Merged

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 2, 2015

Remove query(), entity(), and transaction() methods from Dataset.

56e9c05

Addresses second part of googleapis#477.

dhermes self-assigned this Jan 2, 2015

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 2, 2015

Move Dataset.get_entity to Key.

6479182

Addresses third part of googleapis#477.

dhermes mentioned this issue Jan 2, 2015

datastore.Entity should not know about the dataset #446

Closed

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 2, 2015

Moving Entity.delete to Key (for datastore).

7c04a74

Addresses fourth part of googleapis#477.

dhermes mentioned this issue Jan 2, 2015

Remove Dataset.get_entity and move the functionality to Key #455

Closed

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 2, 2015

Moves Dataset.allocate_ids to connection module.

149c766

Addresses fifth part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 3, 2015

Moves Dataset.get_entities to connection module.

1682683

Addresses sixth part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 6, 2015

Implements datastore.set_default_connection.

9e4ee08

This allows methods which rely on a connection to be used with no arguments. Fixes first part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 6, 2015

Remove query(), entity(), and transaction() methods from Dataset.

6ef0156

Addresses second part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 6, 2015

Move Dataset.get_entity to Key.

0a51f4a

Addresses third part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 6, 2015

Move Dataset.get_entity to Key.

62204e7

Addresses third part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 6, 2015

Moving Entity.delete to Key (for datastore).

a741516

Addresses fourth part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 6, 2015

Moves Dataset.allocate_ids to connection module.

c401bbc

Addresses fifth part of googleapis#477.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 6, 2015

Moves Dataset.get_entities to __init__ module.

d2a1446

Addresses sixth part of googleapis#477.

tseaver mentioned this issue Jan 7, 2015

477: Prepare to remove dataset #499

Closed

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Jan 7, 2015

Removing datastore.Dataset class and its uses.

e998859

Addresses part 8 of googleapis#477.

dhermes mentioned this issue Jan 7, 2015

Removing datastore.Dataset class and its uses. #500

Merged

dhermes mentioned this issue Jan 8, 2015

Updating documentation to reflect bulk datastore API changes. #506

Merged

dhermes closed this as completed in 073478a Jan 8, 2015

dhermes reopened this Jan 8, 2015

dhermes closed this as completed Jan 8, 2015

dhermes mentioned this issue Jan 8, 2015

Remove cyclic imports or just stop worrying and love the bomb #517

Closed

jgeewax modified the milestone: Datastore Stable Jan 30, 2015

yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020

atulep pushed a commit that referenced this issue Apr 6, 2023

chore(deps): update dependency mock to v5.0.1 (#477)

759f2f7

atulep pushed a commit that referenced this issue Apr 6, 2023

chore(deps): update dependency mock to v5.0.1 (#477)

bfed5de

atulep pushed a commit that referenced this issue Apr 18, 2023

chore(deps): update dependency mock to v5.0.1 (#477)

c354f12

parthea pushed a commit that referenced this issue Sep 22, 2023

chore(deps): update dependency pytest to v7.2.1 (#477)

c9401e4

parthea pushed a commit that referenced this issue Oct 21, 2023

chore: added extra variables owlbot kokoro configs (#477)

42999da

parthea pushed a commit that referenced this issue Oct 21, 2023

chore(main): release 3.10.1 (#477)

4142543

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this issue Oct 22, 2023

chore(deps): update dependency mock to v5.0.1 (#477)

06842e8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove datastore.Dataset class #477

Remove datastore.Dataset class #477

dhermes commented Jan 2, 2015

dhermes commented Jan 8, 2015

dhermes commented Jan 8, 2015

Remove datastore.Dataset class #477

Remove datastore.Dataset class #477

Comments

dhermes commented Jan 2, 2015

dhermes commented Jan 8, 2015

dhermes commented Jan 8, 2015