Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BQML get_model snippets tests are failing #8082

Closed
tswast opened this issue May 21, 2019 · 0 comments · Fixed by #8083
Closed

BQML get_model snippets tests are failing #8082

tswast opened this issue May 21, 2019 · 0 comments · Fixed by #8083
Assignees
@tswast
Labels
api: bigquery Issues related to the BigQuery API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tswast
Copy link
Contributor

tswast commented May 21, 2019

#8049 (comment)

Appears that there's a new field in the response message. I thought protobuf was supposed to ignore unknown fields, but maybe that's not the default. I'll see if I can get a fix today to the Python client.
@tswast tswast self-assigned this May 21, 2019
@tswast tswast added api: bigquery Issues related to the BigQuery API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 21, 2019
@tswast tswast mentioned this issue May 21, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tswast tswast

Labels
api: bigquery Issues related to the BigQuery API. priority: p0 Highest priority. Critical issue. P0 implies highest priority. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BigQuery: avoid errors from unknown fields in Models API. tswast/google-cloud-python
1 participant
@tswast