fix: update resume token for restarting BiDi streams #10282

crwilcox · 2020-01-30T21:12:35Z

b/148467493

firestore/google/cloud/firestore_v1/watch.py

crwilcox added 2 commits January 29, 2020 13:02

fix: fetch updated resume tokens for restarting of stream

eb98435

fix: Improve DummyRPC to call initial_request when necessary

19a7e59

crwilcox requested review from frankyn and tseaver as code owners January 30, 2020 21:12

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 30, 2020

crwilcox changed the title ~~fix: Update resume token for restarting BiDi streams.~~ fix: update resume token for restarting BiDi streams Jan 30, 2020

schmidt-sebastian reviewed Jan 30, 2020

View reviewed changes

firestore/google/cloud/firestore_v1/watch.py Outdated Show resolved Hide resolved

fix: rename method to reflect request is not initial only

3c170a3

crwilcox force-pushed the fix-resume-token-restart-bidi branch from a6558a5 to 3c170a3 Compare January 31, 2020 00:09

fix: adjust test to use new function name

a20b5d8

crwilcox merged commit 970ed4c into googleapis:master Jan 31, 2020

tseaver mentioned this pull request Aug 27, 2020

Firestore listener stops receiving changes after a long time but without throwing an error googleapis/python-firestore#18

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: update resume token for restarting BiDi streams #10282

fix: update resume token for restarting BiDi streams #10282

crwilcox commented Jan 30, 2020

fix: update resume token for restarting BiDi streams #10282

fix: update resume token for restarting BiDi streams #10282

Conversation

crwilcox commented Jan 30, 2020