Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intersphinx for docs linking. #1036

Merged
merged 1 commit into from
Aug 6, 2015

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Aug 5, 2015

NOTE: Has #1035 as base.

@dhermes dhermes added the docs label Aug 5, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2015
@dhermes
Copy link
Contributor Author

dhermes commented Aug 5, 2015

@tseaver Rebased

@tseaver
Copy link
Contributor

tseaver commented Aug 6, 2015

I still don't see a point to the pythonlocal mapping: no Python programmer is going to need to look any of those values up.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 6, 2015

It's nice to add the links. Somehow it feels inconsistent to link to some objects and not to others.

I'm not sure who it hurts.

@dhermes
Copy link
Contributor Author

dhermes commented Aug 6, 2015

@tseaver It turns out I just wasn't using the right refs (e.g. using :class: when I needed to be used :data:). There is no need for the pythonlocal rule. I rebased and got rid of it and also added an intersphinx rule for httplib2 (I found it yesterday).

@tseaver
Copy link
Contributor

tseaver commented Aug 6, 2015

Great! LGTM

dhermes added a commit that referenced this pull request Aug 6, 2015
Add intersphinx for docs linking.
@dhermes dhermes merged commit 42fa77d into googleapis:master Aug 6, 2015
@dhermes dhermes deleted the add-intersphinx branch August 6, 2015 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants