Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial BQ system tests #1047

Merged
merged 6 commits into from Aug 12, 2015
Merged

Initial BQ system tests #1047

merged 6 commits into from Aug 12, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 7, 2015

Uses #1046 as a base.

@tseaver tseaver added the api: bigquery Issues related to the BigQuery API. label Aug 7, 2015
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 7, 2015
dhermes
dhermes reviewed Aug 8, 2015
View reviewed changes
system_tests/bigquery.py

rows = ()
counter = 9
# Allow for 90 seconds of "warm up" before rows visible. See:

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver
Copy link
Contributor Author

tseaver commented Aug 11, 2015

Rebased after landing #1046.

dhermes
dhermes reviewed Aug 11, 2015
View reviewed changes
system_tests/bigquery.py
self.assertEqual(dataset.friendly_name, None)
self.assertEqual(dataset.description, None)
dataset.patch(friendly_name='Friendly', description='Description')
self.assertEqual(dataset.friendly_name, 'Friendly')

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver mentioned this pull request Aug 12, 2015
Closed
dhermes
dhermes reviewed Aug 12, 2015
View reviewed changes
system_tests/bigquery.py
self.assertTrue(token is None)
created = [table for table in all_tables
if table.name in tables_to_create and
table._dataset.name == DATASET_NAME]

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Aug 12, 2015

LGTM (please file issue / find other way to follow up with the protected access)

@tseaver tseaver mentioned this pull request Aug 12, 2015
Closed
tseaver added a commit that referenced this pull request Aug 12, 2015
@tseaver
Merge pull request #1047 from tseaver/bigquery-system_tests
5467dde 
Initial BQ system tests
@tseaver tseaver merged commit 5467dde into googleapis:master Aug 12, 2015
@tseaver tseaver deleted the bigquery-system_tests branch August 12, 2015 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @dhermes @googlebot