Bring all disparate datetime handling into core helpers module. #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we can test all code-paths, just not the branch where Python 2.6 is active.
Using a method to convert to microseconds (which handles both naive datetime objects and ones with timezones other than UTC) and then converts them to microseconds. All consumers then convert to the desired granularity.
Also making it require a float (or int) instead of bailing out for NoneType. Changing the use of the method in bigquery to not pass potentially null values and to multiply by 1000.0 (convert from millis to micros). Also updating micros -> datetime conversion in datastore to use the newly converted method.
googlebot
added
the
cla: yes
| :returns: milliseconds since epoch for ``when`` | ||
| """ | ||
| micros = _microseconds_from_datetime(when) | ||
| millis, _ = divmod(micros, 1000) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Other than the one quibble, LGTM |
|
Addressed |
dhermes
added a commit
that referenced
this pull request
Aug 12, 2015
Bring all disparate datetime handling into core helpers module.
This was referenced Aug 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024.
This is best reviewed commit by commit. I'm happy to break it into more PRs if desired.