Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [google-cloud-filestore] Added REGIONAL tier support in the v1 API #12022

Merged
merged 2 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
24 changes: 12 additions & 12 deletions packages/google-cloud-filestore/CONTRIBUTING.rst
Original file line number Diff line number Diff line change
Expand Up @@ -35,21 +35,21 @@ Using a Development Checkout
You'll have to create a development environment using a Git checkout:

- While logged into your GitHub account, navigate to the
``python-filestore`` `repo`_ on GitHub.
``google-cloud-python`` `repo`_ on GitHub.

- Fork and clone the ``python-filestore`` repository to your GitHub account by
- Fork and clone the ``google-cloud-python`` repository to your GitHub account by
clicking the "Fork" button.

- Clone your fork of ``python-filestore`` from your GitHub account to your local
- Clone your fork of ``google-cloud-python`` from your GitHub account to your local
computer, substituting your account username and specifying the destination
as ``hack-on-python-filestore``. E.g.::
as ``hack-on-google-cloud-python``. E.g.::

$ cd ${HOME}
$ git clone git@github.com:USERNAME/python-filestore.git hack-on-python-filestore
$ cd hack-on-python-filestore
# Configure remotes such that you can pull changes from the googleapis/python-filestore
$ git clone git@github.com:USERNAME/google-cloud-python.git hack-on-google-cloud-python
$ cd hack-on-google-cloud-python
# Configure remotes such that you can pull changes from the googleapis/google-cloud-python
# repository into your local repository.
$ git remote add upstream git@github.com:googleapis/python-filestore.git
$ git remote add upstream git@github.com:googleapis/google-cloud-python.git
# fetch and merge changes from upstream into main
$ git fetch upstream
$ git merge upstream/main
Expand All @@ -60,7 +60,7 @@ repo, from which you can submit a pull request.
To work on the codebase and run the tests, we recommend using ``nox``,
but you can also use a ``virtualenv`` of your own creation.

.. _repo: https://github.com/googleapis/python-filestore
.. _repo: https://github.com/googleapis/google-cloud-python

Using ``nox``
=============
Expand Down Expand Up @@ -113,7 +113,7 @@ Coding Style
export GOOGLE_CLOUD_TESTING_BRANCH="main"

By doing this, you are specifying the location of the most up-to-date
version of ``python-filestore``. The
version of ``google-cloud-python``. The
remote name ``upstream`` should point to the official ``googleapis``
checkout and the branch should be the default branch on that remote (``main``).

Expand Down Expand Up @@ -209,7 +209,7 @@ The `description on PyPI`_ for the project comes directly from the
``README``. Due to the reStructuredText (``rst``) parser used by
PyPI, relative links which will work on GitHub (e.g. ``CONTRIBUTING.rst``
instead of
``https://github.com/googleapis/python-filestore/blob/main/CONTRIBUTING.rst``)
``https://github.com/googleapis/google-cloud-python/blob/main/CONTRIBUTING.rst``)
may cause problems creating links or rendering the description.

.. _description on PyPI: https://pypi.org/project/google-cloud-filestore
Expand All @@ -236,7 +236,7 @@ We support:

Supported versions can be found in our ``noxfile.py`` `config`_.

.. _config: https://github.com/googleapis/python-filestore/blob/main/packages/google-cloud-filestore/noxfile.py
.. _config: https://github.com/googleapis/google-cloud-python/blob/main/packages/google-cloud-filestore/noxfile.py


**********
Expand Down
2 changes: 1 addition & 1 deletion packages/google-cloud-filestore/docs/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@
html_theme_options = {
"description": "Google Cloud Client Libraries for google-cloud-filestore",
"github_user": "googleapis",
"github_repo": "python-filestore",
"github_repo": "google-cloud-python",
"github_banner": True,
"font_family": "'Roboto', Georgia, sans",
"head_font_family": "'Roboto', Georgia, serif",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
NetworkConfig,
NfsExportOptions,
RestoreInstanceRequest,
RevertInstanceRequest,
Snapshot,
UpdateBackupRequest,
UpdateInstanceRequest,
Expand Down Expand Up @@ -76,6 +77,7 @@
"NetworkConfig",
"NfsExportOptions",
"RestoreInstanceRequest",
"RevertInstanceRequest",
"Snapshot",
"UpdateBackupRequest",
"UpdateInstanceRequest",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
NetworkConfig,
NfsExportOptions,
RestoreInstanceRequest,
RevertInstanceRequest,
Snapshot,
UpdateBackupRequest,
UpdateInstanceRequest,
Expand Down Expand Up @@ -74,6 +75,7 @@
"NetworkConfig",
"NfsExportOptions",
"RestoreInstanceRequest",
"RevertInstanceRequest",
"Snapshot",
"UpdateBackupRequest",
"UpdateInstanceRequest",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@
"restore_instance"
]
},
"RevertInstance": {
"methods": [
"revert_instance"
]
},
"UpdateBackup": {
"methods": [
"update_backup"
Expand Down Expand Up @@ -160,6 +165,11 @@
"restore_instance"
]
},
"RevertInstance": {
"methods": [
"revert_instance"
]
},
"UpdateBackup": {
"methods": [
"update_backup"
Expand Down Expand Up @@ -245,6 +255,11 @@
"restore_instance"
]
},
"RevertInstance": {
"methods": [
"revert_instance"
]
},
"UpdateBackup": {
"methods": [
"update_backup"
Expand Down