Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix verb / target for 'Metric.create' / 'Sink.create'. #1616

Merged
merged 1 commit into from Mar 17, 2016
Merged

Fix verb / target for 'Metric.create' / 'Sink.create'. #1616

merged 1 commit into from Mar 17, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 15, 2016

@tseaver
Fix verb/target for 'Metric.create'/'Sink.create'.
15526df 
- Spec mandates 'POST' to the container, rather than 'PUT' to the
  putative URL of the entity itself.

- Note that metric creation worked before;  sink creation is blocked
  due to permission issues (see #1614).
@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Mar 15, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 15, 2016

@dhermes PTAL. System tests which create metrics work both ways; a new system test for creating sinks fails (see #1614).

@dhermes
Copy link
Contributor

dhermes commented Mar 16, 2016

How do you mean "worked before"? Also, why the change needed? Was the previous implementation not based on the docs?

@tseaver
Copy link
Contributor Author

tseaver commented Mar 16, 2016

How do you mean "worked before"?

The system tests for #1610, #1611, #1612, #1613 were all running cleanly using PUT to the not-yet-existing metric's URI.

Also, why the change needed? Was the previous implementation not based on the docs?

I misread the docs, because I was looking at the create wrappers for otther APIs (pubsub, search) which use PUT to create resources.

@dhermes
Copy link
Contributor

dhermes commented Mar 17, 2016

LGTM

tseaver added a commit that referenced this pull request Mar 17, 2016
@tseaver
Merge pull request #1616 from tseaver/logging-sink_metric_fix_create_…
466409e 
…verb_target

Fix verb / target for 'Metric.create' / 'Sink.create'.
@tseaver tseaver merged commit 466409e into googleapis:logging-api Mar 17, 2016
@tseaver tseaver deleted the logging-sink_metric_fix_create_verb_target branch March 17, 2016 03:10
@tseaver tseaver mentioned this pull request Mar 17, 2016
Merged
@dhermes dhermes mentioned this pull request Apr 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tseaver @dhermes @googlebot