Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Subscription.set_iam_policy' API wrapper. #1645

Merged
merged 4 commits into from Mar 22, 2016
Merged

Add 'Subscription.set_iam_policy' API wrapper. #1645

merged 4 commits into from Mar 22, 2016

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Mar 21, 2016

Uses #1644 as a base.

Toward #1073.

@tseaver tseaver added the api: pubsub Issues related to the Pub/Sub API. label Mar 21, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 21, 2016
@tseaver
Copy link
Contributor Author

tseaver commented Mar 22, 2016

@dhermes Rebased after merging #1644 to master. PTAL

>>> subscription = topic.subscription('subscription_name')
>>> policy = subscription.get_iam_policy() # API request
>>> policy.writers.add(policy.group('editors-list@example.com'))
>>> subscriptoin.set_iam_policy(policy) # API request

This comment was marked as spam.

This comment was marked as spam.

@dhermes
Copy link
Contributor

dhermes commented Mar 22, 2016

LGTM other than a few small nits

tseaver added a commit that referenced this pull request Mar 22, 2016
Add 'Subscription.set_iam_policy' API wrapper.
@tseaver tseaver merged commit efc1d41 into googleapis:master Mar 22, 2016
@tseaver tseaver deleted the pubsub-subscription-set_iam_policy branch March 22, 2016 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants